Files
@ 21c6a1e5bf6c
Branch filter:
Location: kallithea/scripts/validate-commits - annotation
21c6a1e5bf6c
1.4 KiB
text/plain
i18n: drop automaticly introduced bad translations - completely remove previously fuzzy translations, not just the fuzzy markers
This is redoing cb02ca192180, but more aggressively.
msgmerge is aggressively adding fuzzy translations of strings that vaguely
resemble each other. But these translations are bad. And even more bad almost
irreversible when we dropped the fuzzy markers.
Consider for example the translation in 0.4.1 at
https://kallithea-scm.org/repos/kallithea/files/da65398a62fff50f3d241796cbf17acdea2092ef/kallithea/i18n/be/LC_MESSAGES/kallithea.po
"Unauthorized access to resource" is translated to "Несанкцыянаваны доступ да
рэсурсу", but the same translation is also used fuzzily for very different
strings. That can't be good. While the translation of a slightly similar string
might be a good starting point for translators, we don't want to show such
automated and invalid translations to our users. Then it is better to show the
orginal english text, that at least is a clear TODO item and doesn't say
anything wrong.
We thus remove these automaticly generated translations. Some of them were
perhaps marked fuzzy for other reasons, and we might lose a few good
translations. That is still better than having wrong translations. Translators
can also just mark the translation as non-fuzzy and deal with the conflict of
diverging opinion on whether the translation is good. Their statement trumps
our presumption that the automated fuzzy translation is bad.
This is redoing cb02ca192180, but more aggressively.
msgmerge is aggressively adding fuzzy translations of strings that vaguely
resemble each other. But these translations are bad. And even more bad almost
irreversible when we dropped the fuzzy markers.
Consider for example the translation in 0.4.1 at
https://kallithea-scm.org/repos/kallithea/files/da65398a62fff50f3d241796cbf17acdea2092ef/kallithea/i18n/be/LC_MESSAGES/kallithea.po
"Unauthorized access to resource" is translated to "Несанкцыянаваны доступ да
рэсурсу", but the same translation is also used fuzzily for very different
strings. That can't be good. While the translation of a slightly similar string
might be a good starting point for translators, we don't want to show such
automated and invalid translations to our users. Then it is better to show the
orginal english text, that at least is a clear TODO item and doesn't say
anything wrong.
We thus remove these automaticly generated translations. Some of them were
perhaps marked fuzzy for other reasons, and we might lose a few good
translations. That is still better than having wrong translations. Translators
can also just mark the translation as non-fuzzy and deal with the conflict of
diverging opinion on whether the translation is good. Their statement trumps
our presumption that the automated fuzzy translation is bad.
37ac2ac0a9ae 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 d9e37f7fd35b 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 69f70de15f26 | #!/bin/bash
# Validate the specified commits against test suite and other checks.
if [ -n "$VIRTUAL_ENV" ]; then
echo "Please run this script from outside a virtualenv."
exit 1
fi
if ! hg update --check -q .; then
echo "Working dir is not clean, please commit/revert changes first."
exit 1
fi
venv=$(mktemp -d kallithea-validatecommits-env-XXXXXX)
resultfile=$(mktemp kallithea-validatecommits-result-XXXXXX)
echo > "$resultfile"
cleanup()
{
rm -rf /tmp/kallithea-test*
rm -rf "$venv"
}
finish()
{
cleanup
# print (possibly intermediate) results
cat "$resultfile"
rm "$resultfile"
}
trap finish EXIT
for rev in $(hg log -r "$1" -T '{node}\n'); do
hg log -r "$rev"
hg update "$rev"
cleanup
virtualenv -p "$(command -v python2)" "$venv"
source "$venv/bin/activate"
pip install --upgrade pip setuptools
pip install -e . -r dev_requirements.txt python-ldap python-pam
# run-all-cleanup
scripts/run-all-cleanup
if ! hg update --check -q .; then
echo "run-all-cleanup did not give clean results!"
result="NOK"
hg diff
hg revert -a
else
result=" OK"
fi
echo "$result: $rev (run-all-cleanup)" >> "$resultfile"
# pytest
if py.test; then
result=" OK"
else
result="NOK"
fi
echo "$result: $rev (pytest)" >> "$resultfile"
deactivate
echo
done
|