Files
@ 260a7a01b054
Branch filter:
Location: kallithea/docs/contributing.rst - annotation
260a7a01b054
1.2 KiB
text/prs.fallenstein.rst
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
bb35ad076e2f bb35ad076e2f 17c9393e9645 8af52e1224ff bb35ad076e2f bb35ad076e2f 8af52e1224ff 8af52e1224ff bb35ad076e2f 8af52e1224ff 9472a0150bf0 8af52e1224ff 8b8edfc25856 9472a0150bf0 8b8edfc25856 9472a0150bf0 053983a464e4 6fdc3b25bc7c 6fdc3b25bc7c 053983a464e4 6fdc3b25bc7c 950110f3f99f 950110f3f99f 950110f3f99f 8b8edfc25856 6fdc3b25bc7c 950110f3f99f 950110f3f99f 6fdc3b25bc7c 1b9d6b0a92b3 1b9d6b0a92b3 950110f3f99f 8af52e1224ff 8af52e1224ff 9472a0150bf0 9472a0150bf0 9472a0150bf0 9472a0150bf0 | .. _contributing:
=========================
Contributing to RhodeCode
=========================
If you would like to contribute to RhodeCode, please contact me, any help is
greatly appreciated!
Could I request that you make your source contributions by first forking the
RhodeCode repository on bitbucket_
https://bitbucket.org/marcinkuzminski/rhodecode and then make your changes to
your forked repository. Please post all fixes into **BETA** branch since your
fix might be already fixed there and i try to merge all fixes from beta into
stable, and not the other way. Finally, when you are finished making a change,
please send me a pull request.
To run RhodeCode in a development version you always need to install the latest
required libs from `requires.txt` file.
after downloading/pulling RhodeCode make sure you run::
python setup.py develop
command to install/verify all required packages, and prepare development
enviroment.
After finishing your changes make sure all tests passes ok. You can run
the testsuite running ``nosetest`` from the project root, or if you use tox
run tox for python2.5-2.7 with multiple database test.
| Thank you for any contributions!
| Marcin
.. _bitbucket: http://bitbucket.org/
|