Files
@ 260a7a01b054
Branch filter:
Location: kallithea/docs/usage/locking.rst - annotation
260a7a01b054
1.3 KiB
text/prs.fallenstein.rst
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 | .. _locking:
===================================
RhodeCode repository locking system
===================================
| Repos with **locking function=disabled** is the default, that's how repos work
today.
| Repos with **locking function=enabled** behaves like follows:
Repos have a state called `locked` that can be true or false.
The hg/git commands `hg/git clone`, `hg/git pull`, and `hg/git push`
influence this state:
- The command `hg/git pull <repo>` will lock that repo (locked=true)
if the user has write/admin permissions on this repo
- The command `hg/git clone <repo>` will lock that repo (locked=true) if the
user has write/admin permissions on this repo
RhodeCode will remember the user id who locked the repo
only this specific user can unlock the repo (locked=false) by calling
- `hg/git push <repo>`
every other command on that repo from this user and
every command from any other user will result in http return code 423 (locked)
additionally the http error includes the <user> that locked the repo
(e.g. “repository <repo> locked by user <user>”)
So the scenario of use for repos with `locking function` enabled is that
every initial clone and every pull gives users (with write permission)
the exclusive right to do a push.
Each repo can be manually unlocked by admin from the repo settings menu.
|