Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/config/pre_receive_tmpl.py - annotation
260a7a01b054
848 B
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 | #!/usr/bin/env python
import os
import sys
try:
import rhodecode
RC_HOOK_VER = '_TMPL_'
os.environ['RC_HOOK_VER'] = RC_HOOK_VER
from rhodecode.lib.hooks import handle_git_pre_receive
except ImportError:
rhodecode = None
def main():
if rhodecode is None:
# exit with success if we cannot import rhodecode !!
# this allows simply push to this repo even without
# rhodecode
sys.exit(0)
repo_path = os.path.abspath('.')
push_data = sys.stdin.readlines()
# os.environ is modified here by a subprocess call that
# runs git and later git executes this hook.
# Environ get's some additional info from rhodecode system
# like IP or username from basic-auth
handle_git_pre_receive(repo_path, push_data, os.environ)
sys.exit(0)
if __name__ == '__main__':
main()
|