Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/lib/__init__.py - annotation
260a7a01b054
862 B
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
70e646b2806a 70e646b2806a 70e646b2806a a9888895b60d 70e646b2806a 70e646b2806a 70e646b2806a cf51bbfb120e a9888895b60d 70e646b2806a 70e646b2806a 70e646b2806a 324ac367a4da 324ac367a4da 70e646b2806a 70e646b2806a 70e646b2806a 70e646b2806a 70e646b2806a 67168195a676 a9888895b60d b5a5a60608a7 b5a5a60608a7 b5a5a60608a7 70e646b2806a | import os
def get_current_revision(quiet=False):
"""
Returns tuple of (number, id) from repository containing this package
or None if repository could not be found.
:param quiet: prints error for fetching revision if True
"""
try:
from rhodecode.lib.vcs import get_repo
from rhodecode.lib.vcs.utils.helpers import get_scm
repopath = os.path.join(os.path.dirname(__file__), '..', '..')
scm = get_scm(repopath)[0]
repo = get_repo(path=repopath, alias=scm)
tip = repo.get_changeset()
return (tip.revision, tip.short_id)
except Exception, err:
if not quiet:
print ("WARNING: Cannot retrieve rhodecode's revision. "
"disregard this if you don't know what that means. "
"Original error was: %s" % err)
return None
|