Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/lib/dbmigrate/__init__.py - annotation
260a7a01b054
2.0 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
9753e0907827 9753e0907827 9753e0907827 9753e0907827 6832ef664673 9753e0907827 6832ef664673 9753e0907827 9753e0907827 89efedac4e6c 9753e0907827 9753e0907827 a671db5bdd58 a671db5bdd58 a671db5bdd58 a671db5bdd58 6832ef664673 9753e0907827 9753e0907827 9753e0907827 9753e0907827 6832ef664673 9753e0907827 a671db5bdd58 9753e0907827 08d2dcd71666 08d2dcd71666 08d2dcd71666 ad66bd0e5601 9753e0907827 60cbde084047 9753e0907827 08d2dcd71666 9753e0907827 3bd2e94cbfc8 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 b76a595b7a5e 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 28a4bb11bb6f 9753e0907827 08d2dcd71666 28a4bb11bb6f 9753e0907827 60cbde084047 60cbde084047 60cbde084047 ad66bd0e5601 60cbde084047 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 9753e0907827 | # -*- coding: utf-8 -*-
"""
rhodecode.lib.dbmigrate.__init__
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Database migration modules
:created_on: Dec 11, 2010
:author: marcink
:copyright: (C) 2010-2012 Marcin Kuzminski <marcin@python-works.com>
:license: GPLv3, see COPYING for more details.
"""
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import logging
from sqlalchemy import engine_from_config
from rhodecode.lib.utils import BasePasterCommand, Command, add_cache
from rhodecode.lib.db_manage import DbManage
log = logging.getLogger(__name__)
class UpgradeDb(BasePasterCommand):
"""Command used for paster to upgrade our database to newer version
"""
max_args = 1
min_args = 1
usage = "CONFIG_FILE"
summary = "Upgrades current db to newer version"
group_name = "RhodeCode"
parser = Command.standard_parser(verbose=True)
def command(self):
from pylons import config
add_cache(config)
db_uri = config['sqlalchemy.db1.url']
dbmanage = DbManage(log_sql=True, dbconf=db_uri,
root=config['here'], tests=False)
dbmanage.upgrade()
def update_parser(self):
self.parser.add_option('--sql',
action='store_true',
dest='just_sql',
help="Prints upgrade sql for further investigation",
default=False)
|