Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/lib/dbmigrate/versions/007_version_1_4_0.py - annotation
260a7a01b054
1.7 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a c9baaacb670a | import logging
import datetime
from sqlalchemy import *
from sqlalchemy.exc import DatabaseError
from sqlalchemy.orm import relation, backref, class_mapper
from sqlalchemy.orm.session import Session
from sqlalchemy.ext.declarative import declarative_base
from rhodecode.lib.dbmigrate.migrate import *
from rhodecode.lib.dbmigrate.migrate.changeset import *
from rhodecode.model.meta import Base
from rhodecode.model import meta
log = logging.getLogger(__name__)
def upgrade(migrate_engine):
"""
Upgrade operations go here.
Don't create your own engine; bind migrate_engine to your metadata
"""
#==========================================================================
# CHANGESET_COMMENTS
#==========================================================================
from rhodecode.lib.dbmigrate.schema.db_1_4_0 import ChangesetComment
tbl_name = ChangesetComment.__tablename__
tbl = Table(tbl_name,
MetaData(bind=migrate_engine), autoload=True,
autoload_with=migrate_engine)
col = tbl.columns.revision
# remove nullability from revision field
col.alter(nullable=True)
#==========================================================================
# REPOSITORY
#==========================================================================
from rhodecode.lib.dbmigrate.schema.db_1_4_0 import Repository
tbl = Repository.__table__
updated_on = Column('updated_on', DateTime(timezone=False),
nullable=True, unique=None)
# create created on column for future lightweight main page
updated_on.create(table=tbl)
def downgrade(migrate_engine):
meta = MetaData()
meta.bind = migrate_engine
|