Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/lib/middleware/errormator.py - annotation
260a7a01b054
1.1 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 dbe3cfb81446 9937afa7f093 | # -*- coding: utf-8 -*-
"""
rhodecode.lib.middleware.errormator
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
middleware to handle errormator publishing of errors
:created_on: October 18, 2012
:author: marcink
:copyright: (C) 2010-2012 Marcin Kuzminski <marcin@python-works.com>
:license: GPLv3, see COPYING for more details.
"""
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
try:
from errormator_client import make_errormator_middleware
except ImportError:
Errormator = None
else:
Errormator = make_errormator_middleware
|