Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/lib/vcs/conf/settings.py - annotation
260a7a01b054
872 B
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da 324ac367a4da | import os
import tempfile
from rhodecode.lib.vcs.utils.paths import get_user_home
abspath = lambda * p: os.path.abspath(os.path.join(*p))
VCSRC_PATH = os.environ.get('VCSRC_PATH')
if not VCSRC_PATH:
HOME_ = get_user_home()
if not HOME_:
HOME_ = tempfile.gettempdir()
VCSRC_PATH = VCSRC_PATH or abspath(HOME_, '.vcsrc')
if os.path.isdir(VCSRC_PATH):
VCSRC_PATH = os.path.join(VCSRC_PATH, '__init__.py')
BACKENDS = {
'hg': 'vcs.backends.hg.MercurialRepository',
'git': 'vcs.backends.git.GitRepository',
}
ARCHIVE_SPECS = {
'tar': ('application/x-tar', '.tar'),
'tbz2': ('application/x-bzip2', '.tar.bz2'),
'tgz': ('application/x-gzip', '.tar.gz'),
'zip': ('application/zip', '.zip'),
}
BACKENDS = {
'hg': 'rhodecode.lib.vcs.backends.hg.MercurialRepository',
'git': 'rhodecode.lib.vcs.backends.git.GitRepository',
}
|