Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/admin/repos_groups/repos_groups_add.html - annotation
260a7a01b054
1.9 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 1f334a68d057 3bce31f026b8 eacd33e0c5b3 3bce31f026b8 f91d3f9b7230 f91d3f9b7230 f91d3f9b7230 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 f91d3f9b7230 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 3bce31f026b8 e0b069468de0 3bce31f026b8 3bce31f026b8 43b8e161be3f 3bce31f026b8 3bce31f026b8 f91d3f9b7230 43b8e161be3f 43b8e161be3f e0b069468de0 43b8e161be3f 43b8e161be3f 43b8e161be3f 43b8e161be3f 43b8e161be3f f91d3f9b7230 43b8e161be3f 43b8e161be3f e0b069468de0 43b8e161be3f 43b8e161be3f cbc644d96a53 43b8e161be3f f91d3f9b7230 f91d3f9b7230 3bce31f026b8 7ae36df760ce f91d3f9b7230 3bce31f026b8 3bce31f026b8 3bce31f026b8 f91d3f9b7230 f91d3f9b7230 | ## -*- coding: utf-8 -*-
<%inherit file="/base/base.html"/>
<%def name="title()">
${_('Add repos group')} · ${c.rhodecode_name}
</%def>
<%def name="breadcrumbs_links()">
${h.link_to(_('Admin'),h.url('admin_home'))}
»
${h.link_to(_('Repos groups'),h.url('repos_groups'))}
»
${_('add new repos group')}
</%def>
<%def name="page_nav()">
${self.menu('admin')}
</%def>
<%def name="main()">
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
</div>
<!-- end box / title -->
${h.form(url('repos_groups'))}
<div class="form">
<!-- fields -->
<div class="fields">
<div class="field">
<div class="label">
<label for="group_name">${_('Group name')}:</label>
</div>
<div class="input">
${h.text('group_name',class_='medium')}
</div>
</div>
<div class="field">
<div class="label label-textarea">
<label for="group_description">${_('Description')}:</label>
</div>
<div class="textarea text-area editor">
${h.textarea('group_description',cols=23,rows=5,class_="medium")}
</div>
</div>
<div class="field">
<div class="label">
<label for="group_parent_id">${_('Group parent')}:</label>
</div>
<div class="input">
${h.select('group_parent_id',request.GET.get('parent_group'),c.repo_groups,class_="medium")}
</div>
</div>
<div class="buttons">
${h.submit('save',_('save'),class_="ui-btn large")}
</div>
</div>
</div>
${h.end_form()}
</div>
</%def>
|