Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/admin/users_groups/users_group_add.html - annotation
260a7a01b054
1.5 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c 1f334a68d057 fff21c9b075c fff21c9b075c f91d3f9b7230 f91d3f9b7230 5f1850e4712a fff21c9b075c 5f1850e4712a fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c f91d3f9b7230 fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c f91d3f9b7230 fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c fff21c9b075c 9cbfb5c97078 fff21c9b075c fff21c9b075c f91d3f9b7230 fff21c9b075c 7ae36df760ce f91d3f9b7230 fff21c9b075c fff21c9b075c fff21c9b075c f91d3f9b7230 f91d3f9b7230 | ## -*- coding: utf-8 -*-
<%inherit file="/base/base.html"/>
<%def name="title()">
${_('Add user group')} · ${c.rhodecode_name}
</%def>
<%def name="breadcrumbs_links()">
${h.link_to(_('Admin'),h.url('admin_home'))}
»
${h.link_to(_('User groups'),h.url('users_groups'))}
»
${_('add new user group')}
</%def>
<%def name="page_nav()">
${self.menu('admin')}
</%def>
<%def name="main()">
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
</div>
<!-- end box / title -->
${h.form(url('users_groups'))}
<div class="form">
<!-- fields -->
<div class="fields">
<div class="field">
<div class="label">
<label for="users_group_name">${_('Group name')}:</label>
</div>
<div class="input">
${h.text('users_group_name',class_='small')}
</div>
</div>
<div class="field">
<div class="label label-checkbox">
<label for="users_group_active">${_('Active')}:</label>
</div>
<div class="checkboxes">
${h.checkbox('users_group_active',value=True, checked='checked')}
</div>
</div>
<div class="buttons">
${h.submit('save',_('save'),class_="ui-btn large")}
</div>
</div>
</div>
${h.end_form()}
</div>
</%def>
|