Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/admin/users_groups/users_groups.html - annotation
260a7a01b054
2.0 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 1f334a68d057 83d35d716a02 83d35d716a02 83d35d716a02 f74be3359044 f74be3359044 5f1850e4712a 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 663f4f26776a 83d35d716a02 f91d3f9b7230 f91d3f9b7230 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 fff21c9b075c f467c75544af fff21c9b075c 83d35d716a02 fff21c9b075c f6d57d055d1e 5f1850e4712a 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 83d35d716a02 | ## -*- coding: utf-8 -*-
<%inherit file="/base/base.html"/>
<%def name="title()">
${_('User groups administration')} · ${c.rhodecode_name}
</%def>
<%def name="breadcrumbs_links()">
${h.link_to(_('Admin'),h.url('admin_home'))}
»
${_('user groups')}
</%def>
<%def name="page_nav()">
${self.menu('admin')}
</%def>
<%def name="main()">
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
<ul class="links">
<li>
<span>${h.link_to(_(u'Add new user group'),h.url('new_users_group'))}</span>
</li>
</ul>
</div>
<!-- end box / title -->
<div class="table">
<table class="table_disp">
<tr class="header">
<th class="left">${_('group name')}</th>
<th class="left">${_('members')}</th>
<th class="left">${_('active')}</th>
<th class="left">${_('action')}</th>
</tr>
%for cnt,u_group in enumerate(c.users_groups_list):
<tr class="parity${cnt%2}">
<td>${h.link_to(u_group.users_group_name,h.url('edit_users_group', id=u_group.users_group_id))}</td>
<td><span class="tooltip" title="${h.tooltip(', '.join(map(h.safe_unicode,[x.user.username for x in u_group.members[:50]])))}">${len(u_group.members)}</span></td>
<td>${h.bool2icon(u_group.users_group_active)}</td>
<td>
${h.form(url('users_group', id=u_group.users_group_id),method='delete')}
${h.submit('remove_',_('delete'),id="remove_group_%s" % u_group.users_group_id,
class_="delete_icon action_button",onclick="return confirm('"+_('Confirm to delete this user group: %s') % u_group.users_group_name+"');")}
${h.end_form()}
</td>
</tr>
%endfor
</table>
</div>
</div>
</%def>
|