Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/errors/error_document.html - annotation
260a7a01b054
2.0 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
1e757ac98988 7a5eeafb1a9a c9a9e0b3baf8 1e757ac98988 1e757ac98988 1e757ac98988 7a5eeafb1a9a 7a5eeafb1a9a d5e42c00f3c1 7a5eeafb1a9a b4f401524060 b4f401524060 b4f401524060 f91d3f9b7230 1e757ac98988 cabe887a9829 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 f91d3f9b7230 1e757ac98988 1e757ac98988 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 03028bf372d7 1e757ac98988 f91d3f9b7230 b4f401524060 b4f401524060 b4f401524060 f91d3f9b7230 b4f401524060 f91d3f9b7230 b4f401524060 b4f401524060 b4f401524060 f91d3f9b7230 b4f401524060 1e757ac98988 1e757ac98988 1e757ac98988 1e757ac98988 f91d3f9b7230 1e757ac98988 | ## -*- coding: utf-8 -*-
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Error - ${c.error_message}</title>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
<meta name="robots" content="index, nofollow"/>
<link rel="icon" href="${h.url('/images/icons/database_gear.png')}" type="image/png" />
<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
%if c.redirect_time:
<meta http-equiv="refresh" content="${c.redirect_time}; url=${c.url_redirect}"/>
%endif
<!-- stylesheets -->
<link rel="stylesheet" type="text/css" href="${h.url('/css/style.css')}" media="screen" />
<style type="text/css">
#main_div{
border: 0px solid #000;
width: 500px;
margin: auto;
text-align: center;
margin-top: 200px;
font-size: 1.6em;
}
.error_message{
text-align: center;
color:#003367;
font-size: 1.6em;
margin:10px;
}
</style>
</head>
<body>
<div class="flash_msg">
<% messages = h.flash.pop_messages() %>
% if messages:
<ul id="flash-messages">
% for message in messages:
<li class="${message.category}_msg">${message}</li>
% endfor
</ul>
% endif
</div>
<div id="login">
<div class="table">
<div id="main_div">
<div style="font-size:2.0em;margin: 10px">${c.rhodecode_name}</div>
<h1 class="error_message">${c.error_message}</h1>
<p>${c.error_explanation}</p>
%if c.redirect_time:
<p>${_('You will be redirected to %s in %s seconds') % (c.redirect_module,c.redirect_time)}</p>
%endif
</div>
</div>
<!-- end login -->
</div>
</body>
</html>
|