Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/search/search_commit.html - annotation
260a7a01b054
1.8 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 88b0e82bcba4 88b0e82bcba4 9c12bff04ec7 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d c25cc1c7c65f 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d 5f21a9dcb09d | ##commit highligthing
%for cnt,sr in enumerate(c.formated_results):
%if h.HasRepoPermissionAny('repository.write','repository.read','repository.admin')(sr['repository'],'search results check'):
<div class="table">
<div id="body${cnt}" class="codeblock">
<div class="code-header">
<div class="search-path">${h.link_to(h.literal('%s » %s' % (sr['repository'],sr['raw_id'])),
h.url('changeset_home',repo_name=sr['repository'],revision=sr['raw_id']))}
${h.fmt_date(h.time_to_datetime(sr['date']))}
</div>
</div>
<div class="left">
<div class="author">
<div class="gravatar">
<img alt="gravatar" src="${h.gravatar_url(h.email_or_none(sr['author']),20)}"/>
</div>
<span>${h.person(sr['author'])}</span><br/>
<span><a href="mailto:${h.email_or_none(sr['author'])}">${h.email_or_none(sr['author'])}</a></span><br/>
</div>
%if sr['message_hl']:
<div class="search-code-body">
<pre>${h.literal(sr['message_hl'])}</pre>
</div>
%else:
<div class="message">${h.urlify_commit(sr['message'], sr['repository'])}</div>
%endif
</div>
</div>
</div>
%else:
%if cnt == 0:
<div class="table">
<div id="body${cnt}" class="codeblock">
<div class="error">${_('Permission denied')}</div>
</div>
</div>
%endif
%endif
%endfor
%if c.cur_query and c.formated_results:
<div class="pagination-wh pagination-left">
${c.formated_results.pager('$link_previous ~2~ $link_next')}
</div>
%endif
|