Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/search/search_content.html - annotation
260a7a01b054
1.1 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 b6c902d88472 b6c902d88472 b6c902d88472 65b2f150beb7 b6c902d88472 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 f91d3f9b7230 65b2f150beb7 f91d3f9b7230 f91d3f9b7230 65b2f150beb7 65b2f150beb7 65b2f150beb7 65b2f150beb7 f91d3f9b7230 f91d3f9b7230 | ##content highligthing
%for cnt,sr in enumerate(c.formated_results):
%if h.HasRepoPermissionAny('repository.write','repository.read','repository.admin')(sr['repository'],'search results check'):
<div class="table">
<div id="body${cnt}" class="codeblock">
<div class="code-header">
<div class="search-path">${h.link_to(h.literal('%s » %s' % (sr['repository'],sr['f_path'])),
h.url('files_home',repo_name=sr['repository'],revision='tip',f_path=sr['f_path']))}
</div>
</div>
<div class="search-code-body">
<pre>${h.literal(sr['content_short_hl'])}</pre>
</div>
</div>
</div>
%else:
%if cnt == 0:
<div class="table">
<div id="body${cnt}" class="codeblock">
<div class="error">${_('Permission denied')}</div>
</div>
</div>
%endif
%endif
%endfor
%if c.cur_query and c.formated_results:
<div class="pagination-wh pagination-left">
${c.formated_results.pager('$link_previous ~2~ $link_next')}
</div>
%endif
|