Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/search/search_path.html - annotation
260a7a01b054
870 B
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
65b2f150beb7 387971bd1a79 387971bd1a79 387971bd1a79 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 387971bd1a79 387971bd1a79 b4f401524060 b4f401524060 b4f401524060 b4f401524060 b4f401524060 387971bd1a79 f91d3f9b7230 f91d3f9b7230 387971bd1a79 387971bd1a79 387971bd1a79 387971bd1a79 f91d3f9b7230 387971bd1a79 | ##path search
%for cnt,sr in enumerate(c.formated_results):
%if h.HasRepoPermissionAny('repository.write','repository.read','repository.admin')(sr['repository'],'search results check'):
<div class="search_path">
<div class="link">
${h.link_to(h.literal('%s » %s' % (sr['repository'],sr['f_path'])),
h.url('files_home',repo_name=sr['repository'],revision='tip',f_path=sr['f_path']))}
</div>
</div>
%else:
%if cnt == 0:
<div class="error">
<div class="link">
${_('Permission denied')}
</div>
</div>
%endif
%endif
%endfor
%if c.cur_query and c.formated_results:
<div class="pagination-wh pagination-left">
${c.formated_results.pager('$link_previous ~2~ $link_next')}
</div>
%endif
|