Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/switch_to_list.html - annotation
260a7a01b054
1.8 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
f91d3f9b7230 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 46e10b3de4e3 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 f91d3f9b7230 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 46e10b3de4e3 0069657aaf42 0069657aaf42 0069657aaf42 0069657aaf42 f91d3f9b7230 a3ee2611e6e8 f91d3f9b7230 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 46e10b3de4e3 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 f91d3f9b7230 f91d3f9b7230 f91d3f9b7230 | ## -*- coding: utf-8 -*-
<li>
${h.link_to('%s (%s)' % (_('branches'),len(c.rhodecode_repo.branches.values()),),h.url('branches_home',repo_name=c.repo_name),class_='branches childs')}
<ul>
%if c.rhodecode_repo.branches.values():
%for cnt,branch in enumerate(c.rhodecode_repo.branches.items()):
<li><div><pre>${h.link_to('%s - %s' % (branch[0],h.short_id(branch[1])),h.url('files_home',repo_name=c.repo_name,revision=(branch[0] if '/' not in branch[0] else branch[1]), at=branch[0]))}</pre></div></li>
%endfor
%else:
<li>${h.link_to(_('There are no branches yet'),'#')}</li>
%endif
</ul>
</li>
<li>
${h.link_to('%s (%s)' % (_('tags'),len(c.rhodecode_repo.tags.values()),),h.url('tags_home',repo_name=c.repo_name),class_='tags childs')}
<ul>
%if c.rhodecode_repo.tags.values():
%for cnt,tag in enumerate(c.rhodecode_repo.tags.items()):
<li><div><pre>${h.link_to('%s - %s' % (tag[0],h.short_id(tag[1])),h.url('files_home',repo_name=c.repo_name,revision=(tag[0] if '/' not in tag[0] else tag[1]), at=tag[0]))}</pre></div></li>
%endfor
%else:
<li>${h.link_to(_('There are no tags yet'),'#')}</li>
%endif
</ul>
</li>
%if c.rhodecode_repo.alias == 'hg':
<li>
${h.link_to('%s (%s)' % (_('bookmarks'),len(c.rhodecode_repo.bookmarks.values()),),h.url('bookmarks_home',repo_name=c.repo_name),class_='bookmarks childs')}
<ul>
%if c.rhodecode_repo.bookmarks.values():
%for cnt,book in enumerate(c.rhodecode_repo.bookmarks.items()):
<li><div><pre>${h.link_to('%s - %s' % (book[0],h.short_id(book[1])),h.url('files_home',repo_name=c.repo_name,revision=(book[0] if '/' not in book[0] else book[1]), at=book[0]))}</pre></div></li>
%endfor
%else:
<li>${h.link_to(_('There are no bookmarks yet'),'#')}</li>
%endif
</ul>
</li>
%endif
|