Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/tests/functional/test_journal.py - annotation
260a7a01b054
1.6 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
49eb69d78988 0765fd5bf668 0765fd5bf668 0ea8eca2d63e 49eb69d78988 25029d6f4b47 49eb69d78988 49eb69d78988 49eb69d78988 0765fd5bf668 49eb69d78988 0ea8eca2d63e 4910b2607a29 0765fd5bf668 0765fd5bf668 0765fd5bf668 8ecc6b8229a5 8ecc6b8229a5 0765fd5bf668 8ecc6b8229a5 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 0765fd5bf668 25029d6f4b47 25029d6f4b47 25029d6f4b47 0765fd5bf668 25029d6f4b47 25029d6f4b47 25029d6f4b47 | from rhodecode.tests import *
from rhodecode.model.db import UserFollowing, User, Repository
from rhodecode.lib.helpers import get_token
import datetime
class TestJournalController(TestController):
def test_index(self):
self.log_user()
response = self.app.get(url(controller='journal', action='index'))
response.mustcontain("""<div class="journal_day">%s</div>""" % datetime.date.today())
def test_stop_following_repository(self):
session = self.log_user()
# usr = self.Session.query(User).filter(User.username == 'test_admin').one()
# repo = self.Session.query(Repository).filter(Repository.repo_name == HG_REPO).one()
#
# followings = self.Session.query(UserFollowing)\
# .filter(UserFollowing.user == usr)\
# .filter(UserFollowing.follows_repository == repo).all()
#
# assert len(followings) == 1, 'Not following any repository'
#
# response = self.app.post(url(controller='journal',
# action='toggle_following'),
# {'auth_token':get_token(session),
# 'follows_repo_id':repo.repo_id})
def test_start_following_repository(self):
self.log_user()
response = self.app.get(url(controller='journal', action='index'),)
def test_public_journal_atom(self):
self.log_user()
response = self.app.get(url(controller='journal', action='public_journal_atom'),)
def test_public_journal_rss(self):
self.log_user()
response = self.app.get(url(controller='journal', action='public_journal_rss'),)
|