Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/tests/functional/test_repos_groups.py - annotation
260a7a01b054
1.8 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
2ab211e0aecd 2ab211e0aecd b4daef4cc26d 2ab211e0aecd 2ab211e0aecd 2ab211e0aecd b4daef4cc26d 2ab211e0aecd 5f1850e4712a 2ab211e0aecd b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d 2ab211e0aecd 2ab211e0aecd b4daef4cc26d 2ab211e0aecd 2ab211e0aecd b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d b4daef4cc26d | from rhodecode.tests import *
class TestReposGroupsController(TestController):
def test_index(self):
self.log_user()
response = self.app.get(url('repos_groups'))
response.mustcontain('There are no repository groups yet')
# def test_index_as_xml(self):
# response = self.app.get(url('formatted_repos_groups', format='xml'))
#
# def test_create(self):
# response = self.app.post(url('repos_groups'))
def test_new(self):
self.log_user()
response = self.app.get(url('new_repos_group'))
def test_new_by_regular_user(self):
self.log_user(TEST_USER_REGULAR_LOGIN, TEST_USER_REGULAR_PASS)
response = self.app.get(url('new_repos_group'), status=403)
#
# def test_new_as_xml(self):
# response = self.app.get(url('formatted_new_repos_group', format='xml'))
#
# def test_update(self):
# response = self.app.put(url('repos_group', group_name=1))
#
# def test_update_browser_fakeout(self):
# response = self.app.post(url('repos_group', group_name=1), params=dict(_method='put'))
#
# def test_delete(self):
# self.log_user()
# response = self.app.delete(url('repos_group', group_name=1))
#
# def test_delete_browser_fakeout(self):
# response = self.app.post(url('repos_group', group_name=1), params=dict(_method='delete'))
#
# def test_show(self):
# response = self.app.get(url('repos_group', group_name=1))
#
# def test_show_as_xml(self):
# response = self.app.get(url('formatted_repos_group', group_name=1, format='xml'))
#
# def test_edit(self):
# response = self.app.get(url('edit_repos_group', group_name=1))
#
# def test_edit_as_xml(self):
# response = self.app.get(url('formatted_edit_repos_group', group_name=1, format='xml'))
|