Files
@ 64d6e8e298a4
Branch filter:
Location: kallithea/docs/usage/locking.rst - annotation
64d6e8e298a4
1.3 KiB
text/prs.fallenstein.rst
comments: don't hide comments made to lines outside the diff context
This is a hack but seems like the best way to solve the problem of users
increasing the context size and then making comments. The way things are done
makes it hard to come up with a better solution.
It should perhaps also be made impossible to comment on lines that isn't
changed in the changeset.
This issue is related to the need for a way to easily navigate to the
(unresolved) comments that has been made on a huge changeset.
This is a hack but seems like the best way to solve the problem of users
increasing the context size and then making comments. The way things are done
makes it hard to come up with a better solution.
It should perhaps also be made impossible to comment on lines that isn't
changed in the changeset.
This issue is related to the need for a way to easily navigate to the
(unresolved) comments that has been made on a huge changeset.
aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 e73a69cb98dc aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 e73a69cb98dc 8b8edfc25856 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 aa17c7a1b8a5 8b8edfc25856 | .. _locking:
===================================
Kallithea repository locking system
===================================
| Repos with **locking function=disabled** is the default, that's how repos work
today.
| Repos with **locking function=enabled** behaves like follows:
Repos have a state called `locked` that can be true or false.
The hg/git commands `hg/git clone`, `hg/git pull`, and `hg/git push`
influence this state:
- The command `hg/git pull <repo>` will lock that repo (locked=true)
if the user has write/admin permissions on this repo
- The command `hg/git clone <repo>` will lock that repo (locked=true) if the
user has write/admin permissions on this repo
Kallithea will remember the user id who locked the repo
only this specific user can unlock the repo (locked=false) by calling
- `hg/git push <repo>`
every other command on that repo from this user and
every command from any other user will result in http return code 423 (locked)
additionally the http error includes the <user> that locked the repo
(e.g. “repository <repo> locked by user <user>”)
So the scenario of use for repos with `locking function` enabled is that
every initial clone and every pull gives users (with write permission)
the exclusive right to do a push.
Each repo can be manually unlocked by admin from the repo settings menu.
|