Files
@ 9855b31d033b
Branch filter:
Location: kallithea/rhodecode/tests/functional/test_admin_ldap_settings.py - annotation
9855b31d033b
3.7 KiB
text/x-python
pullrequests: fix changesets ordering being reversed when creating new pull requests
41b4edf77b5b tried to make the displayed order of changeset consistent: The
topmost is always the latest.
That did however also reverse the ordering of the changesets sent back in the
post when used in the pull request creation form. Displaying the pull request
later on would reverse it again and thus show it in the 'wrong' order.
We now undo that reversing when creating the pull requests, and the stored data
will thus be the same as before.
41b4edf77b5b tried to make the displayed order of changeset consistent: The
topmost is always the latest.
That did however also reverse the ordering of the changesets sent back in the
post when used in the pull request creation form. Displaying the pull request
later on would reverse it again and thus show it in the 'wrong' order.
We now undo that reversing when creating the pull requests, and the stored data
will thus be the same as before.
4bdcc08b04c4 2c0d35e336b5 3dedf3991d40 4bdcc08b04c4 4bdcc08b04c4 4bdcc08b04c4 c0335c1dee36 c0335c1dee36 c0335c1dee36 63e49418a4cc c0335c1dee36 c0335c1dee36 3dedf3991d40 ff2ea58debb5 605707b50d7c cf51bbfb120e 3dedf3991d40 3dedf3991d40 3dedf3991d40 3dedf3991d40 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 3dedf3991d40 2c0d35e336b5 3dedf3991d40 3dedf3991d40 3dedf3991d40 3dedf3991d40 a8f2d78d14ea c0335c1dee36 ff2ea58debb5 3dedf3991d40 ff2ea58debb5 605707b50d7c cf51bbfb120e 3dedf3991d40 3dedf3991d40 3dedf3991d40 3dedf3991d40 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 ff2ea58debb5 cf51bbfb120e 63e49418a4cc 63e49418a4cc cf51bbfb120e c0335c1dee36 c0335c1dee36 c0335c1dee36 c0335c1dee36 c0335c1dee36 | from rhodecode.tests import *
from rhodecode.model.db import RhodeCodeSetting
class TestLdapSettingsController(TestController):
def test_index(self):
self.log_user()
response = self.app.get(url(controller='admin/ldap_settings',
action='index'))
response.mustcontain('LDAP administration')
def test_ldap_save_settings(self):
self.log_user()
if ldap_lib_installed:
raise SkipTest('skipping due to missing ldap lib')
test_url = url(controller='admin/ldap_settings',
action='ldap_settings')
response = self.app.post(url=test_url,
params={'ldap_host': u'dc.example.com',
'ldap_port': '999',
'ldap_tls_kind': 'PLAIN',
'ldap_tls_reqcert': 'NEVER',
'ldap_dn_user': 'test_user',
'ldap_dn_pass': 'test_pass',
'ldap_base_dn': 'test_base_dn',
'ldap_filter': 'test_filter',
'ldap_search_scope': 'BASE',
'ldap_attr_login': 'test_attr_login',
'ldap_attr_firstname': 'ima',
'ldap_attr_lastname': 'tester',
'ldap_attr_email': 'test@example.com' })
new_settings = RhodeCodeSetting.get_ldap_settings()
self.assertEqual(new_settings['ldap_host'], u'dc.example.com',
'fail db write compare')
self.checkSessionFlash(response,
'LDAP settings updated successfully')
def test_ldap_error_form_wrong_port_number(self):
self.log_user()
if ldap_lib_installed:
raise SkipTest('skipping due to missing ldap lib')
test_url = url(controller='admin/ldap_settings',
action='ldap_settings')
response = self.app.post(url=test_url,
params={'ldap_host': '',
'ldap_port': 'i-should-be-number', # bad port num
'ldap_tls_kind': 'PLAIN',
'ldap_tls_reqcert': 'NEVER',
'ldap_dn_user': '',
'ldap_dn_pass': '',
'ldap_base_dn': '',
'ldap_filter': '',
'ldap_search_scope': 'BASE',
'ldap_attr_login': '',
'ldap_attr_firstname': '',
'ldap_attr_lastname': '',
'ldap_attr_email': ''})
response.mustcontain("""<span class="error-message">"""
"""Please enter a number</span><br />""")
def test_ldap_error_form(self):
self.log_user()
if ldap_lib_installed:
raise SkipTest('skipping due to missing ldap lib')
test_url = url(controller='admin/ldap_settings',
action='ldap_settings')
response = self.app.post(url=test_url,
params={'ldap_host': 'Host',
'ldap_port': '123',
'ldap_tls_kind': 'PLAIN',
'ldap_tls_reqcert': 'NEVER',
'ldap_dn_user': '',
'ldap_dn_pass': '',
'ldap_base_dn': '',
'ldap_filter': '',
'ldap_search_scope': 'BASE',
'ldap_attr_login': '', # <----- missing required input
'ldap_attr_firstname': '',
'ldap_attr_lastname': '',
'ldap_attr_email': ''})
response.mustcontain("""<span class="error-message">The LDAP Login"""
""" attribute of the CN must be specified""")
def test_ldap_login(self):
pass
def test_ldap_login_incorrect(self):
pass
|