Files
@ 9855b31d033b
Branch filter:
Location: kallithea/rhodecode/tests/functional/test_shortlog.py - annotation
9855b31d033b
2.9 KiB
text/x-python
pullrequests: fix changesets ordering being reversed when creating new pull requests
41b4edf77b5b tried to make the displayed order of changeset consistent: The
topmost is always the latest.
That did however also reverse the ordering of the changesets sent back in the
post when used in the pull request creation form. Displaying the pull request
later on would reverse it again and thus show it in the 'wrong' order.
We now undo that reversing when creating the pull requests, and the stored data
will thus be the same as before.
41b4edf77b5b tried to make the displayed order of changeset consistent: The
topmost is always the latest.
That did however also reverse the ordering of the changesets sent back in the
post when used in the pull request creation form. Displaying the pull request
later on would reverse it again and thus show it in the 'wrong' order.
We now undo that reversing when creating the pull requests, and the stored data
will thus be the same as before.
1e757ac98988 1e757ac98988 a520d542697e 1e757ac98988 1e757ac98988 a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e 1e757ac98988 a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e a520d542697e | from rhodecode.tests import *
class TestShortlogController(TestController):
def test_index_hg(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
repo_name=HG_REPO))
# Test response...
def test_index_git(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
repo_name=GIT_REPO))
# Test response...
def test_index_hg_with_filenode(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/vcs/exceptions.py',
repo_name=HG_REPO))
#history commits messages
response.mustcontain('Added exceptions module, this time for real')
response.mustcontain('Added not implemented hg backend test case')
response.mustcontain('Added BaseChangeset class')
# Test response...
def test_index_git_with_filenode(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/vcs/exceptions.py',
repo_name=GIT_REPO))
#history commits messages
response.mustcontain('Added exceptions module, this time for real')
response.mustcontain('Added not implemented hg backend test case')
response.mustcontain('Added BaseChangeset class')
def test_index_hg_with_filenode_that_is_dirnode(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/tests',
repo_name=HG_REPO))
self.assertEqual(response.status, '302 Found')
def test_index_git_with_filenode_that_is_dirnode(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/tests',
repo_name=GIT_REPO))
self.assertEqual(response.status, '302 Found')
def test_index_hg_with_filenode_not_existing(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/wrong_path',
repo_name=HG_REPO))
self.assertEqual(response.status, '302 Found')
def test_index_git_with_filenode_not_existing(self):
self.log_user()
response = self.app.get(url(controller='shortlog', action='index',
revision='tip', f_path='/wrong_path',
repo_name=GIT_REPO))
self.assertEqual(response.status, '302 Found')
|