Files
@ ebdd1a89cdd9
Branch filter:
Location: kallithea/pylons_app/model/forms.py - annotation
ebdd1a89cdd9
12.8 KiB
text/x-python
Added extra validation in creating users.
new style errors for users
new style errors for users
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 | 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 556473ba0399 564e40829f80 564e40829f80 5da4ef115006 a55c17874486 a55c17874486 556473ba0399 556473ba0399 556473ba0399 0e5455fda8fd 556473ba0399 0e5455fda8fd 556473ba0399 556473ba0399 556473ba0399 5da4ef115006 564e40829f80 556473ba0399 556473ba0399 556473ba0399 564e40829f80 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 564e40829f80 556473ba0399 556473ba0399 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 ebdd1a89cdd9 a55c17874486 a55c17874486 a55c17874486 a55c17874486 40bccabf4574 40bccabf4574 a55c17874486 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 351013049742 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 a0116e944da1 556473ba0399 556473ba0399 556473ba0399 a55c17874486 a55c17874486 a55c17874486 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 0e5455fda8fd 5bbcc0cac389 5bbcc0cac389 556473ba0399 556473ba0399 5af2cd31c99b 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 5da4ef115006 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 556473ba0399 351013049742 351013049742 556473ba0399 b0715a788432 b0715a788432 b0715a788432 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd cec5cbc956c0 cec5cbc956c0 cec5cbc956c0 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd b0715a788432 0e5455fda8fd 0e5455fda8fd b0715a788432 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd fc4027fe46bc fc4027fe46bc fc4027fe46bc b0715a788432 b0715a788432 b0715a788432 b0715a788432 b0715a788432 b0715a788432 b0715a788432 0e5455fda8fd b0715a788432 b0715a788432 0e5455fda8fd 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 d303aacb3349 d303aacb3349 d303aacb3349 d303aacb3349 d303aacb3349 d303aacb3349 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 cec5cbc956c0 cec5cbc956c0 cec5cbc956c0 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 29370bb76fa6 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 556473ba0399 556473ba0399 556473ba0399 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 564e40829f80 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 a886f5eba757 564e40829f80 564e40829f80 556473ba0399 556473ba0399 556473ba0399 ebdd1a89cdd9 a55c17874486 a55c17874486 a55c17874486 ebdd1a89cdd9 a55c17874486 a55c17874486 aafd9a98ea58 a55c17874486 ebdd1a89cdd9 a55c17874486 a55c17874486 a55c17874486 a55c17874486 a55c17874486 a55c17874486 0e5455fda8fd b0715a788432 0e5455fda8fd 0e5455fda8fd 29370bb76fa6 b0715a788432 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 0e5455fda8fd 29370bb76fa6 0e5455fda8fd 05b212954275 b0715a788432 05b212954275 05b212954275 05b212954275 b0715a788432 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 05b212954275 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 664a5b8c551a 05b212954275 05b212954275 | """ this is forms validation classes
http://formencode.org/module-formencode.validators.html
for list off all availible validators
we can create our own validators
The table below outlines the options which can be used in a schema in addition to the validators themselves
pre_validators [] These validators will be applied before the schema
chained_validators [] These validators will be applied after the schema
allow_extra_fields False If True, then it is not an error when keys that aren't associated with a validator are present
filter_extra_fields False If True, then keys that aren't associated with a validator are removed
if_key_missing NoDefault If this is given, then any keys that aren't available but are expected will be replaced with this value (and then validated). This does not override a present .if_missing attribute on validators. NoDefault is a special FormEncode class to mean that no default values has been specified and therefore missing keys shouldn't take a default value.
ignore_key_missing False If True, then missing keys will be missing in the result, if the validator doesn't have .if_missing on it already
<name> = formencode.validators.<name of validator>
<name> must equal form name
list=[1,2,3,4,5]
for SELECT use formencode.All(OneOf(list), Int())
"""
from formencode import All
from formencode.validators import UnicodeString, OneOf, Int, Number, Regex, \
Email, Bool, StringBoolean
from pylons import session
from pylons.i18n.translation import _
from pylons_app.lib.auth import get_crypt_password
import pylons_app.lib.helpers as h
from pylons_app.model import meta
from pylons_app.model.db import User, Repository
from sqlalchemy.exc import OperationalError
from sqlalchemy.orm.exc import NoResultFound, MultipleResultsFound
from webhelpers.pylonslib.secure_form import authentication_token
import datetime
import formencode
import logging
log = logging.getLogger(__name__)
#this is needed to translate the messages using _() in validators
class State_obj(object):
_ = staticmethod(_)
#===============================================================================
# VALIDATORS
#===============================================================================
class ValidAuthToken(formencode.validators.FancyValidator):
messages = {'invalid_token':_('Token mismatch')}
def validate_python(self, value, state):
if value != authentication_token():
raise formencode.Invalid(self.message('invalid_token', state,
search_number=value), value, state)
def ValidUsername(edit, old_data):
class _ValidUsername(formencode.validators.FancyValidator):
def validate_python(self, value, state):
if value in ['default', 'new_user']:
raise formencode.Invalid(_('Invalid username'), value, state)
#check if user is uniq
sa = meta.Session
old_un = None
if edit:
old_un = sa.query(User).get(old_data.get('user_id')).username
if old_un != value or not edit:
if sa.query(User).filter(User.username == value).scalar():
raise formencode.Invalid(_('This username already exists') ,
value, state)
meta.Session.remove()
return _ValidUsername
class ValidPassword(formencode.validators.FancyValidator):
def to_python(self, value, state):
if value:
return get_crypt_password(value)
class ValidAuth(formencode.validators.FancyValidator):
messages = {
'invalid_password':_('invalid password'),
'invalid_login':_('invalid user name'),
'disabled_account':_('Your acccount is disabled')
}
#error mapping
e_dict = {'username':messages['invalid_login'],
'password':messages['invalid_password']}
e_dict_disable = {'username':messages['disabled_account']}
def validate_python(self, value, state):
sa = meta.Session
crypted_passwd = get_crypt_password(value['password'])
username = value['username']
try:
user = sa.query(User).filter(User.username == username).one()
except (NoResultFound, MultipleResultsFound, OperationalError) as e:
log.error(e)
user = None
raise formencode.Invalid(self.message('invalid_password',
state=State_obj), value, state,
error_dict=self.e_dict)
if user:
if user.active:
if user.username == username and user.password == crypted_passwd:
from pylons_app.lib.auth import AuthUser
auth_user = AuthUser()
auth_user.username = username
auth_user.is_authenticated = True
auth_user.is_admin = user.admin
auth_user.user_id = user.user_id
auth_user.name = user.name
auth_user.lastname = user.lastname
session['hg_app_user'] = auth_user
session.save()
log.info('user %s is now authenticated', username)
try:
user.last_login = datetime.datetime.now()
sa.add(user)
sa.commit()
except (OperationalError) as e:
log.error(e)
sa.rollback()
return value
else:
log.warning('user %s not authenticated', username)
raise formencode.Invalid(self.message('invalid_password',
state=State_obj), value, state,
error_dict=self.e_dict)
else:
log.warning('user %s is disabled', username)
raise formencode.Invalid(self.message('disabled_account',
state=State_obj),
value, state,
error_dict=self.e_dict_disable)
meta.Session.remove()
class ValidRepoUser(formencode.validators.FancyValidator):
def to_python(self, value, state):
sa = meta.Session
try:
self.user_db = sa.query(User)\
.filter(User.active == True)\
.filter(User.username == value).one()
except Exception:
raise formencode.Invalid(_('This username is not valid'),
value, state)
meta.Session.remove()
return self.user_db.user_id
def ValidRepoName(edit, old_data):
class _ValidRepoName(formencode.validators.FancyValidator):
def to_python(self, value, state):
slug = h.repo_name_slug(value)
if slug in ['_admin']:
raise formencode.Invalid(_('This repository name is disallowed'),
value, state)
if old_data.get('repo_name') != value or not edit:
sa = meta.Session
if sa.query(Repository).get(slug):
raise formencode.Invalid(_('This repository already exists') ,
value, state)
meta.Session.remove()
return slug
return _ValidRepoName
class ValidPerms(formencode.validators.FancyValidator):
messages = {'perm_new_user_name':_('This username is not valid')}
def to_python(self, value, state):
perms_update = []
perms_new = []
#build a list of permission to update and new permission to create
for k, v in value.items():
if k.startswith('perm_'):
if k.startswith('perm_new_user'):
new_perm = value.get('perm_new_user', False)
new_user = value.get('perm_new_user_name', False)
if new_user and new_perm:
if (new_user, new_perm) not in perms_new:
perms_new.append((new_user, new_perm))
else:
usr = k[5:]
if usr == 'default':
if value['private']:
#set none for default when updating to private repo
v = 'repository.none'
perms_update.append((usr, v))
value['perms_updates'] = perms_update
value['perms_new'] = perms_new
sa = meta.Session
for k, v in perms_new:
try:
self.user_db = sa.query(User)\
.filter(User.active == True)\
.filter(User.username == k).one()
except Exception:
msg = self.message('perm_new_user_name',
state=State_obj)
raise formencode.Invalid(msg, value, state, error_dict={'perm_new_user_name':msg})
return value
class ValidSettings(formencode.validators.FancyValidator):
def to_python(self, value, state):
#settings form can't edit user
if value.has_key('user'):
del['value']['user']
return value
#===============================================================================
# FORMS
#===============================================================================
class LoginForm(formencode.Schema):
allow_extra_fields = True
filter_extra_fields = True
username = UnicodeString(
strip=True,
min=3,
not_empty=True,
messages={
'empty':_('Please enter a login'),
'tooShort':_('Enter a value %(min)i characters long or more')}
)
password = UnicodeString(
strip=True,
min=3,
not_empty=True,
messages={
'empty':_('Please enter a password'),
'tooShort':_('Enter a value %(min)i characters long or more')}
)
#chained validators have access to all data
chained_validators = [ValidAuth]
def UserForm(edit=False, old_data={}):
class _UserForm(formencode.Schema):
allow_extra_fields = True
filter_extra_fields = True
username = All(UnicodeString(strip=True, min=3, not_empty=True), ValidUsername(edit, old_data))
if edit:
new_password = All(UnicodeString(strip=True, min=3, not_empty=False), ValidPassword)
admin = StringBoolean(if_missing=False)
else:
password = All(UnicodeString(strip=True, min=8, not_empty=True), ValidPassword)
active = StringBoolean(if_missing=False)
name = UnicodeString(strip=True, min=3, not_empty=True)
lastname = UnicodeString(strip=True, min=3, not_empty=True)
email = Email(not_empty=True)
return _UserForm
def RepoForm(edit=False, old_data={}):
class _RepoForm(formencode.Schema):
allow_extra_fields = True
filter_extra_fields = False
repo_name = All(UnicodeString(strip=True, min=1, not_empty=True), ValidRepoName(edit, old_data))
description = UnicodeString(strip=True, min=3, not_empty=True)
private = StringBoolean(if_missing=False)
if edit:
user = All(Int(not_empty=True), ValidRepoUser)
chained_validators = [ValidPerms]
return _RepoForm
def RepoSettingsForm(edit=False, old_data={}):
class _RepoForm(formencode.Schema):
allow_extra_fields = True
filter_extra_fields = False
repo_name = All(UnicodeString(strip=True, min=1, not_empty=True), ValidRepoName(edit, old_data))
description = UnicodeString(strip=True, min=3, not_empty=True)
private = StringBoolean(if_missing=False)
chained_validators = [ValidPerms, ValidSettings]
return _RepoForm
def ApplicationSettingsForm():
class _ApplicationSettingsForm(formencode.Schema):
allow_extra_fields = True
filter_extra_fields = False
app_title = UnicodeString(strip=True, min=3, not_empty=True)
app_auth_realm = UnicodeString(strip=True, min=3, not_empty=True)
return _ApplicationSettingsForm
|