kallithea Changelog /kallithea/templates/data_table/_dt

Changelog - /kallithea/templates/data_table/_dt_elements.html @ 5572eb8d4feb - showing 74 out of 74 revisions

Mads Kiilerich	5572eb8d4feb	3 years ago	html: clarify type of button elements - make it clear if we really want "submit" html: clarify type of button elements - make it clear if we really want "submit" This might fix some real problems. stable
Mads Kiilerich	a36a8804e7be	5 years ago	lib: use webutils for special mako templates - helpers is only for controller web templates default
Ross Thomas	173612a900ef	6 years ago	ui: show toggleable "Follow" status in repo groups' repo list ui: show toggleable "Follow" status in repo groups' repo list It makes sense to show Follow status next to repo names in the repo list, and it is a meaningful and efficient bulk operation to toggle Follow status there. Clicking on the (Un)Follow 'heart' will toggle the caller's follow status for that repo. The repo model already has layering violations - expand on them to compute the follow status of the current user. (Changeset was cherry picked and modified by Mads Kiilerich.) default
Thomas De Schampheleire	c7728c5736fd	7 years ago	templates: narrow down scope of webhelpers.html.literal for HTML injection templates: narrow down scope of webhelpers.html.literal for HTML injection When using webhelpers.html.literal to inject some explicit HTML code with some variable data, there are two approaches: h.literal('some <html> code with %s data' % foobar) or h.literal('some <html> code with %s data') % foobar In the first case, the literal also applies to the contents of variable 'foobar' which may be influenceable by users and thus potentially malicious. In the second case, this term will be escaped by webhelpers. See also the documentation: https://docs.pylonsproject.org/projects/webhelpers/en/latest/modules/html/builder.html#webhelpers.html.builder.literal "Also, if you add another string to this string, the other string will be quoted and you will get back another literal object. Also literal(...) % obj will quote any value(s) from obj." In files_browser.html, the correction of this scope of literal() also means that explicit escaping of node.name can be removed. The escaping is now done automatically by webhelpers as mentioned above. stable
Mads Kiilerich	11f829761032	8 years ago	repos: clean up table button markup to give proper spacing repos: clean up table button markup to give proper spacing Before, it used multiple divs with pull-left to make plain buttons and buttons within forms render horizontally. But by doing so, they were rendered without any space between the buttons. Instead, style forms after buttons to be shown inline. The whitespace will thus give the necessary spacing. The redundant divs are thus removed. default
Mads Kiilerich	a86ebf58c720	8 years ago	templates: drop unused get_repos_as_dict super_user parameter templates: drop unused get_repos_as_dict super_user parameter It was perhaps at some point used to show a content menu. default
Mads Kiilerich	b90b82881398	8 years ago	templates: drop unused code for having repo names link to repo admin page default
domruf	52d4bb85cbbd	8 years ago	icons: replace icon-keyhole-circled with icon-lock for private repositories and gists icons: replace icon-keyhole-circled with icon-lock for private repositories and gists icon-lock is more iconic and easier to recognise. default
domruf	97ea346aa4bd	8 years ago	less: use .label and .label-* style instead of custom .tag less: use .label and .label- style instead of custom .*tag This reduces the code and makes it more consistent. Visualy this results in bold texts (which in case of small fonts is easier to read) and a bit more padding left and right. For a proper spacing, this requires to remove whitespaces before and after the texts inside the labels. Since the name changed from tag to label, also rename the variables and functions. default
domruf	2d8f2a419edb	8 years ago	style: remove whitespace after icons style: remove whitespace after icons Where the additional spacing is needed, we already have a padding-right, so these spaces are unnecessary. But more importantly they cause trouble if text-decoration is used (i.e. underline on hover). default
domruf	73406e83b038	8 years ago	icons: replace icon-minus-circled with icon-trashcan if it means deleting icons: replace icon-minus-circled with icon-trashcan if it means deleting A trashcan represents represents much better a delete action then a circled minus does. default
domruf	17dea2319028	8 years ago	repos: move optional icons after name to better align text in table default
Mads Kiilerich	6db3122e4d75	8 years ago	index: show repositories and repository groups in the same table index: show repositories and repository groups in the same table Having two different tables with their own paging and search gave a bad UI. Instead, do like all other UIs that show directory content and show both "folders" and "files" in the same list. The rendering of repo groups is changed to use js data instead of a taking data from an html table. Repository groups are shoe-horned into the repository DataTable. The columns are no perfect match - some of the existing columns are thus given an empty default value. default
domruf	789de118156b	8 years ago	style: consistently use 'changeset_hash' class for monospace hashes style: consistently use 'changeset_hash' class for monospace hashes Get rid of 'revision-link' and some use of 'hash'. There is still some use of 'hash' for columns, but the content there already has 'changeset_hash'. default
Mads Kiilerich	91182a358fb3	8 years ago	templates: drop odd grid_edit and grid_delete classes templates: drop odd grid_edit and grid_delete classes We really should have both buttons inside the same float-left so they get proper spacing ... but that doesn't work when one is wrapped in a form ... default
domruf	4bd2c3590a22	8 years ago	templates: more consistently put icons inside 'Delete' and 'Edit' buttons templates: more consistently put icons inside 'Delete' and 'Edit' buttons - on repo, repo group, user and user group list page. For now, we keep the text and keep the button visible. The Edit button was typically a submit button, not inside a form but inside an <a>. It did thus not really trigger a submit but just followed the link. Extracted by Mads Kiilerich. default
domruf	ab5c736930cb	8 years ago	templates: fix typo that broke deleting repo groups templates: fix typo that broke deleting repo groups An edit error in 073cf19b5067 broke some of the ways repository groups can be removed. Confusingly, repo groups can be deleted both from their Settings tab and from Advanced. default
domruf	c0e0ae9c5e64	9 years ago	index: only link from the repository and group names - don't include the various icons default
Mads Kiilerich	88ce09daea37	8 years ago	style: remove most of the explicit styles - it should now be good enough in CSS ... and Bootstrap will soon improve it further default
Mads Kiilerich	3dcf1f82311a	9 years ago	controllers: avoid setting request state in controller instances - set it in the thread global request variable controllers: avoid setting request state in controller instances - set it in the thread global request variable In TurboGears, controllers are singletons and we should avoid using instance variables for any volatile data. Instead, use the "global thread local" request context. With everything in request, some use of c is dropped. Note: kallithea/controllers/api/__init__.py still use instance variables that will cause problems with TurboGears. default
domruf	1ab38cd72704	9 years ago	template: use Bootstrap tooltips and popover instead of handmade tooltips template: use Bootstrap tooltips and popover instead of handmade tooltips Based on work from Andrew Shadura <andrew@shadura.me>. Further modified by Mads Kiilerich. show_changeset_tooltip is merged into tooltip_activate. default
Mads Kiilerich	e34cf36e024a	9 years ago	style: introduce pull-left and pull-right in more places style: introduce pull-left and pull-right in more places Based on work by Dominik Ruf. default
Mads Kiilerich	fe879761c235	9 years ago	style: introduce text-nowrap and avoid using direct white-space: nowrap style: introduce text-nowrap and avoid using direct white-space: nowrap Based on work by Dominik Ruf. default
Mads Kiilerich	184c78cfded1	9 years ago	repositories: drop last traces of quick_menu - it died when DataTables were introduced default
Mads Kiilerich	a04ff65be3f6	9 years ago	journal: drop unused controller code for watched repositories default
Mads Kiilerich	ad2a922da0ba	9 years ago	style: temporary style tweaks before Bootstrap style: temporary style tweaks before Bootstrap Some input fields were truncated - especially if 100% width. default
Mads Kiilerich	c40e567e4b82	9 years ago	style: use Bootstrap compatible data-toggle="tooltip" markup style: use Bootstrap compatible data-toggle="tooltip" markup Based on work by Dominik Ruf and Andrew Shadura. default
Mads Kiilerich	7bbe7dfaa48b	9 years ago	style: replace some disabled btn with Bootstrap compatible label markup style: replace some disabled btn with Bootstrap compatible label markup Based on work by Dominik Ruf. default
Mads Kiilerich	b52a66c5755f	9 years ago	style: replace action_button with Bootstrap compatible btn class names style: replace action_button with Bootstrap compatible btn class names Based on work by Dominik Ruf. default
domruf	b7654d1675da	9 years ago	style: in preparation for bootstrap, use bootstrap compatible button class names style: in preparation for bootstrap, use bootstrap compatible button class names Give all buttons a styling (default, success, danger, warning) and rename the sizes to sm and xs. This is a subset of a bigger changeset. The subset was extracted by Mads Kiilerich, mostly by: sed -i \ -e 's,btn btn-small,btn btn-default btn-sm,g' \ -e 's,btn btn-mini,btn btn-default btn-xs,g' \ -e 's,btn-default btn-$xs\\|sm$ btn-$success\\|danger\\|warning$,btn-\2 btn-\1,g' \ -e 's,class_="btn",class_="btn btn-default",g' \ `hg mani` default
Mads Kiilerich	5e69685567c3	9 years ago	routing: use POST to 'delete_users_group' instead of DELETE default
Mads Kiilerich	ad41c9a72a88	9 years ago	routing: use POST to 'delete_repo' instead of DELETE default
Mads Kiilerich	9313feb209eb	9 years ago	routing: use POST to 'delete_user' instead of DELETE default
Mads Kiilerich	073cf19b5067	9 years ago	routing: use 'delete_repo_group' and POST instead of DELETE default
Mads Kiilerich	42976e0d4e2f	9 years ago	db: make repo creation state constants unicode - avoid conversion in sqlalchemy default
Mads Kiilerich	d2b9788d2760	10 years ago	follow: various minor cleanup follow: various minor cleanup A debug session gave no other result than this +0.1 cleanup ... default
Mads Kiilerich	ab5c4d84f99c	10 years ago	repos: fix abuse of dead 'repo' routing repos: fix abuse of dead 'repo' routing The repo "show" controller didn't do anything and was unused. There was a routing GET entry for it but it was only used for generating URLs for DELETE and PUT operations that have separate controllers that happen to have the same URL. Use the right routing entries when generating URLs and drop the dead code. default
Mads Kiilerich	5d161c096260	10 years ago	helpers: drop h.tooltip helpers: drop h.tooltip h.tooltip did more magic in the past - now it just did a douple (or triple?) escape of html. c9cfaeb1cdfe removed most of the need for double escaping - and the places where it is used, it must be 'tagged' with the safe-html-title class. Thus, none of the remaining uses of h.tooltip are relevant (and might even be wrong); normal automatic template escaping is just fine. This is mostly: sed -i 's,title="\${h.tooltip($[^}]*$)}",title="${\1}",g' `hg mani` default
Mads Kiilerich	d04e36ef71a8	10 years ago	data_table: use simple 'escape' function instead of 'tooltip' function data_table: use simple 'escape' function instead of 'tooltip' function The values will end up being double escaped when h.escape is used in template expansion and turned into a string which then will be escaped in the template. default
Mads Kiilerich	148360f533a4	10 years ago	Merge stable default
Mads Kiilerich	c9cfaeb1cdfe	10 years ago	tooltips: fix unsafe insertion of userdata into the DOM as html tooltips: fix unsafe insertion of userdata into the DOM as html This fixes js injection in the admin journal ... and probably also in other places. Tooltips are used both with hardcoded strings (which is safe and simple) and with user provided strings wrapped in html formatting (which requires careful escaping before being put into the DOM as html). The templating will automatically take care of one level of escaping, but here it requires two levels to do it correctly ... and that was not always done correctly. Instead, by default, just insert it into the DOM as text, not as html. The few places where we know the tooltip contains safe html are handled specially - the element is given the safe-html-title class. That is the case in file annotation and in display of tip revision in repo lists. stable
Mads Kiilerich	86b1f3cfe836	11 years ago	spelling: fix title casing on various translated strings spelling: fix title casing on various translated strings Primarily captions on other not-just-text and data. default
Mads Kiilerich	5c6cc20d224b	11 years ago	spelling: fix title casing on translated template strings spelling: fix title casing on translated template strings Primarily texts. default
Mads Kiilerich	959a9fa7d1a1	11 years ago	controllers: remove old auth_token checks - it was only partial CSRF protection default
Thomas De Schampheleire	8924172b07ff	11 years ago	summary: repeat repo type in front of clone URL summary: repeat repo type in front of clone URL Repeatedly, users report cloning problems of the Kallithea sources on IRC, caused by them assuming that it is a Git repository. Try to solve this problem by repeating the repository tag, indicating 'hg' or 'git' in front of the clone URL. Additionally, decrease the font size of the URL a notch, and improve alignment with the repotag by removing top/bottom padding. To avoid duplication of the repotag logic, introduce a mako def for it. default
Andrew Shadura	963e0e2f2a35	11 years ago	template: remove unneeded <pre> from revision links, use CSS instead default
Sean Farley	3b8adbbf03a1	11 years ago	_dt_elements: underline just the repo name not whitespace default
Sean Farley	a75a6e7b1b17	11 years ago	_dt_elements: move style to css file default
Sean Farley	a72714a46d3d	11 years ago	dt_elements: simplify if block into one line to avoid duplicated code default
Sean Farley	91b57eb580f8	11 years ago	quick_repo_menu: fix misalignment default
Sean Farley	5dbc4e4a7d01	11 years ago	font: rename icon-folder-close to icon-folder default
Sean Farley	1619d9ebc1b9	11 years ago	giticon.png: use repotag class to make an icon giticon.png: use repotag class to make an icon A quick search revealed that some old css code was never used, so it was removed. default
Sean Farley	0cb4a35d8248	11 years ago	hgicon.png: use repotag class to make an icon hgicon.png: use repotag class to make an icon The inline 'style' attribute was modified to remove the color but nothing else, as was discussed with other Kallithea devs, since it makes more sense to leave the spacing until another pass of css refactoring. A quick search revealed that some old css code was never used, so it was removed. default
Sean Farley	09e0e0fdc828	11 years ago	_dt_elements: remove unused user_gravatar def default
Sean Farley	83087ae63bd6	11 years ago	gravatar: use helper method to generate retina img tag default
Thomas De Schampheleire	923037eb67d4	11 years ago	spelling: fix various typos spelling: fix various typos This commit fixes various typos or basic English grammar mistakes found by reviewing the kallithea.pot file. Full correction of sentences that are not very well formulated, like missing articles, is out of scope for this commit. Likewise for inconsistent capitalization of strings like 'Repository group'/'Repository Group'. default
Sean Farley	4f6f46362385	11 years ago	icon-sliders: replace with icon-wrench default
Sean Farley	08e21a3a27db	11 years ago	icon-file-alt: replace with icon-docs default
Sean Farley	b5795554c2ca	11 years ago	icon-remove: use new icon-minus-circled instead icon-remove: use new icon-minus-circled instead To remove the css that set the background of the submit input (h.submit), the element needed to be changed to <button>. default
Sean Farley	4cd73f922f85	11 years ago	icon-lock: use icon-keyhole-circled instead of lock for private repos icon-lock: use icon-keyhole-circled instead of lock for private repos The inline 'style' override has been modified to only leave spacing and sizing (removing color). default
Sean Farley	961ef96fcc65	11 years ago	icon-lock-open-alt: use icon-globe to signify public repo icon-lock-open-alt: use icon-globe to signify public repo Tests are also updated. default
Sean Farley	27504cac4127	11 years ago	lock_open.png: replace icon-unlock-* with icon-lock-open-alt lock_open.png: replace icon-unlock-* with icon-lock-open-alt The inline 'style' override has been modified to only leave spacing and sizing (removing color). default
Sean Farley	f14497d6305e	11 years ago	base: change icon-code-fork menu item to use icon-fork default
Sean Farley	13a984ad8cf2	11 years ago	table_gear.png: replace icon-cogs with icon-sliders default
Sean Farley	a141ed9e1b8f	11 years ago	time.png: use new icon-clock font default
Sean Farley	a82f8e1b83aa	11 years ago	icon-rss-squared: remove color override; let css handle it default
Sean Farley	9a66b802aec6	11 years ago	rss_16.png: use new icon-rss-squared font rss_16.png: use new icon-rss-squared font The old png icon had color for its background so the journal template needed to set it to something so that it wasn't lost to transparency. A quick search revealed that some old css code was never used, so it was removed. default
Sean Farley	9930f77b6a79	11 years ago	group_edit.png: replace icon-group with icon-users group_edit.png: replace icon-group with icon-users A quick search revealed that some old css code was never used, so it was removed. default
Sean Farley	93ca0376f30a	11 years ago	clipboard_16: replace icon-file-text with icon-doc-text-inv clipboard_16: replace icon-file-text with icon-doc-text-inv We replace everywhere except for the gist icons since those will be done differently. default
Sean Farley	25c91454b60d	11 years ago	cog.png: use new icon-gear font cog.png: use new icon-gear font A quick search revealed that some old css code was never used, so it was removed. default
Rasmus Selsmark	cfd7894f2d00	11 years ago	Added Settings to repo context menu default
Bradley M. Kuhn	ef60ae4a34ee	11 years ago	Change the blue colors to Conservancy green kallithea-2.2.5-rebrand
Bradley M. Kuhn	d208416c84c6	11 years ago	Rename rhodecode_user to authuser - it is an AuthUser instance kallithea-2.2.5-rebrand
Bradley M. Kuhn	d1addaf7a91e	11 years ago	Second step in two-part process to rename directories. Second step in two-part process to rename directories. This is the actual directory rename. kallithea-2.2.5-rebrand