page: pass url query params to Page instead of passing request.GET.mixed() to .pager

Standardize on one transparent way to use Pager:

Avoid passing random parameters to .pager() ... or any parameters at all.

pull requests: urlify pull request lists to make issue references clickable

Issue references and commit hashes are already clickable in:
- pull request descriptions,
- commit messages
- changelog

but not yet in:
- pull request titles
- pull request listings

The previous commit handled the former case, this commit handles the latter.

pullrequests: fix broken delete button on overview list

428c1193ee40 changed the "Delete" button on the pull request overview page to
no longer be a "submit" button. That broke the functionality: In order for the
form to be submitted, the button needs to be of type submit.

Change it back to "submit".

icons: replace icon-minus-circled with icon-trashcan if it means deleting

A trashcan represents represents much better a delete action then a circled
minus does.

templates: don't abuse elements as links or buttons

Bootstrap recommends using <button>, so most of the time we should use that.

Except if we don't want the additional padding of a button (like for the expand
'button' on the changelog page).

templates: don't use ordinary elements as links or buttons by adding btn styling

Bootstrap recommends using <button>, so most of the time we should use that.

Extracted by Mads Kiilerich.

pagination: avoid superfluous margins - especially when pages are short and pagination isn't shown

Change our webhelpers paginator wrapper to emit full UL (or nothing) instead of
just ILs.

(Browsers still render extra space below the paginator - that is an artifact of
how Bootstrap use inline on the ILs.)

controllers: avoid setting request state in controller instances - set it in the thread global request variable

In TurboGears, controllers are singletons and we should avoid using instance
variables for any volatile data. Instead, use the "global thread local" request
context.

With everything in request, some use of c is dropped.

Note: kallithea/controllers/api/__init__.py still use instance variables that
will cause problems with TurboGears.

style: introduce h2 h3 h4 h5 for emphasis and drop some explicit styling

Based on work by Dominik Ruf.

style: use Bootstrap compatible data-toggle="tooltip" markup

Based on work by Dominik Ruf and Andrew Shadura.

templates: use bootstrap pagination

The origiinal patch has been modified by Mads Kiilerich.

style: replace action_button with Bootstrap compatible btn class names

Based on work by Dominik Ruf.

style: in preparation for Bootstrap, refactor to use Bootstrap compatible form class names

Based on work by Dominik Ruf.

Mostly:

sed -i \
-e 's,<table>,<table class="table">,g' \
-e 's,<div class="fields">,<div class="form-horizontal">,g' \
-e 's,<div class="field">,<div class="form-group">,g' \
-e 's,<label for="\([^"]*\)">,<label class="control-label" for="\1">,g' \
`hg mani`

cat kallithea/public/css/style.css | \
sed -e '/\.fields\>/{p;s/\.fields/.form-horizontal/g}' | \
sed -e '/\.fields\>/s/ {$/,/g' | \
sed -e '/\.field\>/{p;s/\.field\>/.form-group/g}' | \
sed -e '/\.field\>/s/ {$/,/g' | \
sed -e '/\.fields\>.*\.form-group\>/d' | \
sed -e '/\.form-horizontal\>.*\.field\>/d ' | \
cat - > kallithea/public/css/style.css.tmp
mv kallithea/public/css/style.css.tmp kallithea/public/css/style.css

cleanup: use obj.foo_id instead of obj.foo.foo_id

Don't use constructs like obj.user.user_id when obj.user_id works
equally well (and potentially saves a database load).

pull requests: remove immediate invocation of the function defined in pullrequest_data.html

pullrequest_data.html behaved differently when included and when used as
namespace. Keep it simple and just let it define the pullrequest_overview
function.

pull requests: call it 'owner' instead of 'author'

Prepare for making it possible to transfer ownership of PRs.

pullrequests: require extra confirmation before deleting a PR with comments

Make sure we don't lose any valueable data. A PR without comments doesn't have
much value.

helpers: drop h.tooltip

h.tooltip did more magic in the past - now it just did a douple (or triple?)
escape of html.

c9cfaeb1cdfe removed most of the need for double escaping - and the places
where it is used, it must be 'tagged' with the safe-html-title class. Thus,
none of the remaining uses of h.tooltip are relevant (and might even be wrong);
normal automatic template escaping is just fine.

This is mostly:
sed -i 's,title="\${h.tooltip(\([^}]*\))}",title="${\1}",g' `hg mani`

user: rename property username_and_name into full_name_and_username

In analogy of existing properties full_name and full_name_or_username,
rename username_and_name into full_name_and_username.

pullrequest overview: fix 'my pullrequests' overview

Commit bd4f453a0055 fixed the pager links on pullrequest overviews, but
broke the 'my pull requests' page due to insufficient testing and
incomplete Python understanding.

pullrequest overview: fix missing pager links

Commit 0f9a48e0adc3 refactored the pullrequest overview pages, but has a
bug causing no more than 10 pull requests to be shown, without pager links.
The code assumed that 'pager' was a variable, rather than a method, of the
pullrequests structure.

pullrequest overview: show age rather than date

Since pullrequests are supposed to be short-lived, the age is more relevant
than the actual date (which is still shown in a tooltip).

pullrequest overview: add delete button to own pull requests

In anticipation of the re-use of the pullrequest overview to display 'my
pullrequests', add a delete button to all pullrequests owned by the
currently logged-in user.
An explicit width is added to the column because the column is otherwise
unnecessarily large.

pullrequest overview: create overview from a function to allow re-use

In anticipation of re-use of the pullrequest overview, create a def to
generate this overview given a list of pullrequests.

This also adds a check if the given list is empty, and a check if there is a
pager before displaying the paging links.

pullrequest overview: display in table to improve readability

Instead of showing all info in the pullrequest overview right after each
other on the same line, use a table to improve readability.

Additionally, add following information:
- author
- destination repository

The latter is always the same when viewing the list of pullrequests of a
certain repository, but this change already anticipates re-use of this
block in the 'my pullrequests' overview.

The table is still static, non-sortable, since YUI is deprecated and no new
alternative has been decided upon yet. This improvement can be done later.

pullrequest overview: sanitize display style

Remove the unnecessarily large font size on the pullrequest overview to line
up with the styling of 'my pullrequests'.

Additionally, add some whitespace between the 'show closed PRs' link and the
actual list.

pull requests: add url parameters to page link

Previously, closed and from_ parameters not passed to page link.

Second step in two-part process to rename directories.
This is the actual directory rename.