diff --git a/kallithea/templates/changeset/changeset_file_comment.html b/kallithea/templates/changeset/changeset_file_comment.html --- a/kallithea/templates/changeset/changeset_file_comment.html +++ b/kallithea/templates/changeset/changeset_file_comment.html @@ -108,10 +108,14 @@ -## show comment count +## show comment count as "x comments (y inline, z general)" <%def name="comment_count(inline_cnt, general_cnt)"> -${ungettext("%d comment", "%d comments", general_cnt) % general_cnt} ${ungettext("(%d inline)", "(%d inline)", inline_cnt) % inline_cnt} - + ${'%s (%s, %s)' % ( + ungettext("%d comment", "%d comments", inline_cnt + general_cnt) % (inline_cnt + general_cnt), + ungettext("%d inline", "%d inline", inline_cnt) % inline_cnt, + ungettext("%d general", "%d general", general_cnt) % general_cnt + )} + ## generates inlines taken from c.comments var diff --git a/kallithea/tests/functional/test_changeset_comments.py b/kallithea/tests/functional/test_changeset_comments.py --- a/kallithea/tests/functional/test_changeset_comments.py +++ b/kallithea/tests/functional/test_changeset_comments.py @@ -43,7 +43,7 @@ class TestChangeSetCommentsController(Te self.assertEqual(ChangesetComment.query().count(), 1) response.mustcontain( '''
''' - ''' 1 comment (0 inline)''' + ''' 1 comment (0 inline, 1 general)''' ) self.assertEqual(Notification.query().count(), 1) @@ -80,7 +80,7 @@ class TestChangeSetCommentsController(Te self.assertEqual(ChangesetComment.query().count(), 1) response.mustcontain( '''
''' - ''' 0 comments (1 inline)''' + ''' 1 comment (1 inline, 0 general)''' ) response.mustcontain( '''