diff --git a/kallithea/templates/email_templates/pull_request.html b/kallithea/templates/email_templates/pull_request.html --- a/kallithea/templates/email_templates/pull_request.html +++ b/kallithea/templates/email_templates/pull_request.html @@ -9,23 +9,25 @@
- ${_('Pull request from')} + ${_('Pull request')} + ${pr_nice_id} "${pr_title}" + ${_('by')} + ${pr_owner.full_name_and_username}. +
+
+ ${_('from')} ${pr_source_repo} ${_('branch')} ${pr_source_branch} +
${_('to')} ${pr_target_repo} ${_('branch')} ${pr_target_branch}
-
- ${pr_nice_id} "${pr_title}" - ${_('by')} - ${pr_owner.full_name_and_username}. -
diff --git a/kallithea/templates/email_templates/pull_request.txt b/kallithea/templates/email_templates/pull_request.txt --- a/kallithea/templates/email_templates/pull_request.txt +++ b/kallithea/templates/email_templates/pull_request.txt @@ -3,18 +3,19 @@ <%include file="header.txt" args="title=title,link=pr_url"/>\ \ -${_('Pull request from')|n,unicode} \ +${_('Pull request')|n,unicode} \ +${pr_nice_id|n,unicode} \ +"${pr_title|n,unicode}" \ +${_('by')|n,unicode} \ +${pr_owner.full_name_and_username|n,unicode} +${_('from')} \ ${pr_source_repo|n,unicode} \ ${_('branch')|n,unicode} \ -${pr_source_branch|n,unicode} \ +${pr_source_branch|n,unicode} ${_('to')|n,unicode} \ ${pr_target_repo|n,unicode} \ ${_('branch')|n,unicode} \ -${pr_target_branch|n,unicode}: -${pr_nice_id|n,unicode} \ -"${pr_title|n,unicode}" \ -${_('by')|n,unicode} \ -${pr_owner.full_name_and_username|n,unicode}. +${pr_target_branch|n,unicode} ${_('Description')|n,unicode}: diff --git a/kallithea/templates/email_templates/pull_request_comment.html b/kallithea/templates/email_templates/pull_request_comment.html --- a/kallithea/templates/email_templates/pull_request_comment.html +++ b/kallithea/templates/email_templates/pull_request_comment.html @@ -17,23 +17,25 @@
- ${_('Pull request from')} + ${_('Pull request')} + ${pr_nice_id} "${pr_title}" + ${_('by')} + ${pr_owner.full_name_and_username}. +
+
+ ${_('from')} ${pr_source_repo} ${_('branch')} ${pr_source_branch} +
${_('to')} ${pr_target_repo} ${_('branch')} ${pr_target_branch}:
-
- ${pr_nice_id} "${pr_title}" - ${_('by')} - ${pr_owner.full_name_and_username}. -
diff --git a/kallithea/templates/email_templates/pull_request_comment.txt b/kallithea/templates/email_templates/pull_request_comment.txt --- a/kallithea/templates/email_templates/pull_request_comment.txt +++ b/kallithea/templates/email_templates/pull_request_comment.txt @@ -5,17 +5,18 @@ <%include file="comment.txt" args="text=body,author=pr_comment_user,status=status_change,close=closing_pr"/>\ -${_('Pull request from')|n,unicode} \ +${_('Pull request')|n,unicode} \ +${pr_nice_id|n,unicode} \ +"${pr_title|n,unicode}" \ +${_('by')|n,unicode} \ +${pr_owner.full_name_and_username|n,unicode} +${_('from')} \ ${pr_source_repo|n,unicode} \ ${_('branch')|n,unicode} \ -${pr_source_branch|n,unicode} \ +${pr_source_branch|n,unicode} ${_('to')|n,unicode} \ ${pr_target_repo|n,unicode} \ ${_('branch')|n,unicode} \ -${pr_target_branch|n,unicode}: -${pr_nice_id|n,unicode} \ -"${pr_title|n,unicode}" \ -${_('by')|n,unicode} \ -${pr_owner.full_name_and_username|n,unicode}. +${pr_target_branch|n,unicode} <%include file="button.txt" args="url=pr_comment_url,title=_('View Comment')"/>\ diff --git a/kallithea/tests/models/test_dump_html_mails.ref.html b/kallithea/tests/models/test_dump_html_mails.ref.html --- a/kallithea/tests/models/test_dump_html_mails.ref.html +++ b/kallithea/tests/models/test_dump_html_mails.ref.html @@ -891,8 +891,9 @@ Subject: [Review] repo/name PR #7 "The T Added as Reviewer of Pull Request #7 "The Title" by Requesting User (root) -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk Description: @@ -956,23 +957,25 @@ View Pull Request: http://pr.org/7
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1079,8 +1082,9 @@ Subject: [Review] repo/name PR #7 "The T Mention on Pull Request #7 "The Title" by Requesting User (root) -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk Description: @@ -1144,23 +1148,25 @@ View Pull Request: http://pr.org/7
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1274,8 +1280,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -1362,23 +1369,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1438,8 +1447,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -1526,23 +1536,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1604,8 +1616,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -1708,23 +1721,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1786,8 +1801,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -1890,23 +1906,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -1968,8 +1986,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -2071,23 +2090,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -2149,8 +2170,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -2252,23 +2274,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -2332,8 +2356,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -2439,23 +2464,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -
@@ -2519,8 +2546,9 @@ Me too! - and indented on second line -Pull request from https://dev.org/repo branch devbranch to http://mainline.com/repo branch trunk: -#7 "The Title" by u2 u3 (u2). +Pull request #7 "The Title" by u2 u3 (u2) +from https://dev.org/repo branch devbranch +to http://mainline.com/repo branch trunk View Comment: http://pr.org/comment @@ -2626,23 +2654,25 @@ View Comment: http://pr.org/comment
- Pull request from + Pull request + #7 "The Title" + by + u2 u3 (u2). +
+
+ from https://dev.org/repo branch devbranch +
to http://mainline.com/repo branch trunk:
-
- #7 "The Title" - by - u2 u3 (u2). -