# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 2016-09-12 17:41:19
# Node ID 09dc083f461f19ecc2c99e42982a8afa37844a8a
# Parent  995254e30c7bfaeb74e3b813fa0ceb53aef4404e

api: drop odd creation of password when extern_name is set

The check of extern_name and the interpretation of it seems odd.

Also, there is no point in setting a random password. It can't be retrieved and
used, and not setting a password is more secure.

diff --git a/kallithea/controllers/api/api.py b/kallithea/controllers/api/api.py
--- a/kallithea/controllers/api/api.py
+++ b/kallithea/controllers/api/api.py
@@ -677,10 +677,6 @@ class ApiController(JSONRPCController):
         if User.get_by_email(email):
             raise JSONRPCError("email `%s` already exist" % (email,))
 
-        if Optional.extract(extern_name):
-            # generate temporary password if user is external
-            password = PasswordGenerator().gen_password(length=8)
-
         try:
             user = UserModel().create_or_update(
                 username=Optional.extract(username),