# HG changeset patch # User Mads Kiilerich # Date 2014-08-12 13:08:23 # Node ID 1ffa190f686a8a6202931b25b165ce47e3a77e8f # Parent e172e98f3e3582c7372349035c724a80da25a98c pull requests: don't allow status change on closed PRs - aba28699ec41 was pushed prematurely diff --git a/kallithea/controllers/pullrequests.py b/kallithea/controllers/pullrequests.py --- a/kallithea/controllers/pullrequests.py +++ b/kallithea/controllers/pullrequests.py @@ -184,6 +184,9 @@ class PullrequestsController(BaseRepoCon return [g for g in groups if g[0]], selected def _get_is_allowed_change_status(self, pull_request): + if pull_request.is_closed(): + return False + owner = self.authuser.user_id == pull_request.user_id reviewer = self.authuser.user_id in [x.user_id for x in pull_request.reviewers]