# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 2015-04-28 16:45:43
# Node ID 2881dd265f21721f57a55c63e56da21b33c74962
# Parent  58e4670c79024d2e4a55bf3a5bde6240876bb88b

templates: only bind pager event handlers once - avoid "leaks" and repeated page loads

Summary page ended up hammering the server and when pages were loaded one time
extra for each paging click.

Just moving javascript code from the data template (where it would be re-run on
each paging) and to the main page template.

diff --git a/kallithea/templates/changelog/changelog_summary_data.html b/kallithea/templates/changelog/changelog_summary_data.html
--- a/kallithea/templates/changelog/changelog_summary_data.html
+++ b/kallithea/templates/changelog/changelog_summary_data.html
@@ -72,16 +72,6 @@
 
 </table>
 
-<script type="text/javascript">
-  $(document).ready(function(){
-    var $shortlog_data = $('#shortlog_data');
-    $shortlog_data.on('click','.pager_link',function(e){
-      asynchtml(e.target.href, $shortlog_data, function(){tooltip_activate();});
-      e.preventDefault();
-    });
-  });
-</script>
-
 <div class="pagination-wh pagination-left">
 ${c.repo_changesets.pager('$link_previous ~2~ $link_next')}
 </div>
diff --git a/kallithea/templates/followers/followers.html b/kallithea/templates/followers/followers.html
--- a/kallithea/templates/followers/followers.html
+++ b/kallithea/templates/followers/followers.html
@@ -12,6 +12,7 @@
 <%block name="header_menu">
     ${self.menu('repositories')}
 </%block>
+
 <%def name="main()">
 ${self.repo_context_bar('followers')}
 <div class="box">
@@ -26,4 +27,17 @@ ${self.repo_context_bar('followers')}
         </div>
     </div>
 </div>
+<script type="text/javascript">
+  $(document).ready(function(){
+    var $followers = $('#followers');
+    $followers.on('click','.pager_link',function(e){
+        asynchtml(e.target.href, $followers, function(){
+            show_more_event();
+            tooltip_activate();
+            show_changeset_tooltip();
+        });
+        e.preventDefault();
+    });
+  });
+</script>
 </%def>
diff --git a/kallithea/templates/followers/followers_data.html b/kallithea/templates/followers/followers_data.html
--- a/kallithea/templates/followers/followers_data.html
+++ b/kallithea/templates/followers/followers_data.html
@@ -16,18 +16,5 @@
 % endfor
 
 <div class="pagination-wh pagination-left">
-<script type="text/javascript">
-$(document).ready(function(){
-    var $followers = $('#followers');
-    $followers.on('click','.pager_link',function(e){
-        asynchtml(e.target.href, $followers, function(){
-            show_more_event();
-            tooltip_activate();
-            show_changeset_tooltip();
-        });
-        e.preventDefault();
-    });
-});
-</script>
 ${c.followers_pager.pager('$link_previous ~2~ $link_next')}
 </div>
diff --git a/kallithea/templates/forks/forks.html b/kallithea/templates/forks/forks.html
--- a/kallithea/templates/forks/forks.html
+++ b/kallithea/templates/forks/forks.html
@@ -27,4 +27,17 @@ ${self.repo_context_bar('showforks')}
         </div>
     </div>
 </div>
+<script type="text/javascript">
+  $(document).ready(function(){
+      var $forks = $('#forks');
+      $forks.on('click','.pager_link',function(e){
+          asynchtml(e.target.href, $forks, function(){
+              show_more_event();
+              tooltip_activate();
+              show_changeset_tooltip();
+          });
+          e.preventDefault();
+      });
+  });
+</script>
 </%def>
diff --git a/kallithea/templates/forks/forks_data.html b/kallithea/templates/forks/forks_data.html
--- a/kallithea/templates/forks/forks_data.html
+++ b/kallithea/templates/forks/forks_data.html
@@ -24,19 +24,6 @@
         </div>
     % endfor
   <div class="pagination-wh pagination-left">
-  <script type="text/javascript">
-  $(document).ready(function(){
-      var $forks = $('#forks');
-      $forks.on('click','.pager_link',function(e){
-          asynchtml(e.target.href, $forks, function(){
-              show_more_event();
-              tooltip_activate();
-              show_changeset_tooltip();
-          });
-          e.preventDefault();
-      });
-  });
-  </script>
   ${c.forks_pager.pager('$link_previous ~2~ $link_next')}
   </div>
 % else:
diff --git a/kallithea/templates/journal/journal.html b/kallithea/templates/journal/journal.html
--- a/kallithea/templates/journal/journal.html
+++ b/kallithea/templates/journal/journal.html
@@ -70,7 +70,7 @@
         </div>
     </div>
 
-    <script type="text/javascript">
+<script type="text/javascript">
 
     $('#j_filter').click(function(){
         var $jfilter = $('#j_filter');
@@ -334,5 +334,24 @@
         }
     }
 
-    </script>
+</script>
+
+<script type="text/javascript">
+    $(document).ready(function(){
+        var $journal = $('#journal');
+        $journal.on('click','.pager_link',function(e){
+            asynchtml(e.target.href, $journal, function(){
+                show_more_event();
+                tooltip_activate();
+                show_changeset_tooltip();
+            });
+            e.preventDefault();
+        });
+        $('#journal').on('click','.show_more',function(e){
+            var el = e.target;
+            $('#'+el.id.substring(1)).show();
+            $(el.parentNode).hide();
+        });
+    });
+</script>
 </%def>
diff --git a/kallithea/templates/journal/journal_data.html b/kallithea/templates/journal/journal_data.html
--- a/kallithea/templates/journal/journal_data.html
+++ b/kallithea/templates/journal/journal_data.html
@@ -38,24 +38,6 @@
   <div class="pagination-wh pagination-left" style="padding: 0px 0px 0px 10px;">
   ${c.journal_pager.pager('$link_previous ~2~ $link_next')}
   </div>
-    <script type="text/javascript">
-    $(document).ready(function(){
-        var $journal = $('#journal');
-        $journal.on('click','.pager_link',function(e){
-            asynchtml(e.target.href, $journal, function(){
-                show_more_event();
-                tooltip_activate();
-                show_changeset_tooltip();
-            });
-            e.preventDefault();
-        });
-        $('#journal').on('click','.show_more',function(e){
-            var el = e.target;
-            $('#'+el.id.substring(1)).show();
-            $(el.parentNode).hide();
-        });
-    });
-    </script>
 %else:
   <div style="padding:5px 0px 10px 10px;">
       ${_('No entries yet')}
diff --git a/kallithea/templates/summary/summary.html b/kallithea/templates/summary/summary.html
--- a/kallithea/templates/summary/summary.html
+++ b/kallithea/templates/summary/summary.html
@@ -397,4 +397,15 @@ $(document).ready(function(){
 </script>
 %endif
 
+## Shortlog paging
+<script type="text/javascript">
+  $(document).ready(function(){
+    var $shortlog_data = $('#shortlog_data');
+    $shortlog_data.on('click','.pager_link',function(e){
+      asynchtml(e.target.href, $shortlog_data, function(){tooltip_activate();});
+      e.preventDefault();
+    });
+  });
+</script>
+
 </%def>