# HG changeset patch
# User Marcin Kuzminski <marcin@python-works.com>
# Date 2011-12-21 19:22:32
# Node ID 3480002d421e03b684e4b359bcb7e21d17d878cb
# Parent  e84b3d98c07b2f6dbbb5ddb3c880e85214195d9f
# Parent  eb4b755fc6a2314f451f0d3fee8050225ce305d0

merge with bb fork

diff --git a/init.d/rhodecode-upstart.conf b/init.d/rhodecode-upstart.conf
new file mode 100644
--- /dev/null
+++ b/init.d/rhodecode-upstart.conf
@@ -0,0 +1,26 @@
+# rhodecode - run the rhodecode daemon as an upstart job
+# Change variables/paths as necessary and place file /etc/init/rhodecode.conf
+# start/stop/restart as normal upstart job (ie: $ start rhodecode)
+
+description	"RhodeCode Mercurial Server"
+author		"Matt Zuba <matt.zuba@goodwillaz.org"
+
+start on (local-filesystems and runlevel [2345])
+stop on runlevel [!2345]
+
+respawn
+
+umask 0022
+
+env PIDFILE=/var/hg/rhodecode/rhodecode.pid
+env LOGFILE=/var/hg/rhodecode/log/rhodecode.log
+env APPINI=/var/hg/rhodecode/production.ini
+env HOME=/var/hg
+env USER=hg
+env GROUP=hg
+
+exec /var/hg/.virtualenvs/rhodecode/bin/paster serve --user=$USER --group=$GROUP --pid-file=$PIDFILE --log-file=$LOGFILE $APPINI
+
+post-stop script
+	rm $PIDFILE
+end script
diff --git a/rhodecode/controllers/login.py b/rhodecode/controllers/login.py
--- a/rhodecode/controllers/login.py
+++ b/rhodecode/controllers/login.py
@@ -70,6 +70,11 @@ class LoginController(BaseController):
                 auth_user.set_authenticated()
                 cs = auth_user.get_cookie_store()
                 session['rhodecode_user'] = cs
+                # If they want to be remembered, update the cookie
+                if c.form_result['remember'] is not False:
+                    session.cookie_expires = False
+                    session._set_cookie_values()
+                session._update_cookie_out()
                 session.save()
 
                 log.info('user %s is now authenticated and stored in '
@@ -159,7 +164,6 @@ class LoginController(BaseController):
         return redirect(url('login_home'))
 
     def logout(self):
-        del session['rhodecode_user']
-        session.save()
-        log.info('Logging out and setting user as Empty')
+        session.delete()
+        log.info('Logging out and deleting session for user')
         redirect(url('home'))
diff --git a/rhodecode/model/forms.py b/rhodecode/model/forms.py
--- a/rhodecode/model/forms.py
+++ b/rhodecode/model/forms.py
@@ -482,6 +482,8 @@ class LoginForm(formencode.Schema):
                                 'tooShort':_('Enter %(min)i characters or more')}
                                 )
 
+    remember = StringBoolean(if_missing=False)
+    
     chained_validators = [ValidAuth]
 
 def UserForm(edit=False, old_data={}):
diff --git a/rhodecode/templates/login.html b/rhodecode/templates/login.html
--- a/rhodecode/templates/login.html
+++ b/rhodecode/templates/login.html
@@ -44,12 +44,12 @@
                     </div>
                     
                 </div>
-                ##<div class="field">
-                ##    <div class="checkbox">
-                ##        <input type="checkbox" id="remember" name="remember" />
-                ##        <label for="remember">Remember me</label>
-                ##    </div>
-                ##</div>
+                <div class="field">
+                    <div class="checkbox">
+                        <input type="checkbox" id="remember" name="remember" />
+                        <label for="remember">${_('Remember me')}</label>
+                    </div>
+                </div>
                 <div class="buttons">
                     ${h.submit('sign_in',_('Sign In'),class_="ui-button")}
                 </div>