# HG changeset patch # User Marcin Kuzminski # Date 2013-06-11 14:40:00 # Node ID 39798d53c65d611fd1e0ba380980e058a671d873 # Parent 7e9494f4c4bfcf84878882a24384dda15f5354de When using apply to children flag in repo group permission change prompt, RhodeCode only applied this to user groups if repository was private. Only thing that shouldn't be allowed is to change the DEFAULT user permission when repository is private. diff --git a/rhodecode/model/repos_group.py b/rhodecode/model/repos_group.py --- a/rhodecode/model/repos_group.py +++ b/rhodecode/model/repos_group.py @@ -185,8 +185,9 @@ class ReposGroupModel(BaseModel): repos_group=obj, user=user, perm=perm ) elif isinstance(obj, Repository): - #we do this ONLY IF repository is non-private - if obj.private: + # private repos will not allow to change the default permissions + # using recursive mode + if obj.private and user == User.DEFAULT_USER: return # we set group permission but we have to switch to repo @@ -208,6 +209,8 @@ class ReposGroupModel(BaseModel): RepoModel().grant_users_group_permission( repo=obj, group_name=users_group, perm=perm ) + + # start updates updates = [] log.debug('Now updating permissions for %s in recursive mode:%s' % (repos_group, recursive))