# HG changeset patch
# User Mads Kiilerich <mads@kiilerich.com>
# Date 2019-12-27 01:50:40
# Node ID 4780af2c6ff2d8e380a66f471c4c40f132f5dc92
# Parent  67eeb02062feff43aab838c664788a56cd1a3d1a

api: better error logging for API usage errors - say which request failed to encode response

diff --git a/kallithea/controllers/api/__init__.py b/kallithea/controllers/api/__init__.py
--- a/kallithea/controllers/api/__init__.py
+++ b/kallithea/controllers/api/__init__.py
@@ -240,7 +240,7 @@ class JSONRPCController(TGController):
         try:
             return json.dumps(response)
         except TypeError as e:
-            log.error('API FAILED. Error encoding response: %s', e)
+            log.error('API FAILED. Error encoding response for %s %s: %s\n%s', action, rpc_args, e, traceback.format_exc())
             return json.dumps(
                 dict(
                     id=self._req_id,
diff --git a/kallithea/controllers/api/api.py b/kallithea/controllers/api/api.py
--- a/kallithea/controllers/api/api.py
+++ b/kallithea/controllers/api/api.py
@@ -2400,7 +2400,7 @@ class ApiController(JSONRPCController):
             pull_request=pull_request.pull_request_id,
             f_path=None,
             line_no=None,
-            status_change=(ChangesetStatus.get_status_lbl(status)),
+            status_change=ChangesetStatus.get_status_lbl(status),
             closing_pr=close_pr
         )
         action_logger(apiuser,