# HG changeset patch
# User Marcin Kuzminski <marcin@python-works.com>
# Date 2011-10-17 00:18:12
# Node ID 4d841e56523757b780ec6ff3a159603479c2ec04
# Parent  a682eda608402bd2db776a796b6b0c32e0694910

added validation of params on settings table

diff --git a/rhodecode/controllers/admin/repos.py b/rhodecode/controllers/admin/repos.py
--- a/rhodecode/controllers/admin/repos.py
+++ b/rhodecode/controllers/admin/repos.py
@@ -80,7 +80,7 @@ class ReposController(BaseController):
         self.__load_defaults()
 
         c.repo_info = db_repo = Repository.get_by_repo_name(repo_name)
-        repo = scm_repo = db_repo.scm_instance
+        repo = db_repo.scm_instance
 
         if c.repo_info is None:
             h.flash(_('%s repository is not mapped to db perhaps'
diff --git a/rhodecode/model/db.py b/rhodecode/model/db.py
--- a/rhodecode/model/db.py
+++ b/rhodecode/model/db.py
@@ -32,9 +32,9 @@ from datetime import date
 from sqlalchemy import *
 from sqlalchemy.exc import DatabaseError
 from sqlalchemy.ext.hybrid import hybrid_property
-from sqlalchemy.orm import relationship, backref, joinedload, class_mapper
+from sqlalchemy.orm import relationship, backref, joinedload, class_mapper, \
+    validates
 from sqlalchemy.orm.interfaces import MapperExtension
-
 from beaker.cache import cache_region, region_invalidate
 
 from vcs import get_backend
@@ -150,6 +150,11 @@ class RhodeCodeSettings(Base, BaseModel)
         self.app_settings_value = v
 
 
+    @validates('_app_settings_value')
+    def validate_settings_value(self, key, val):
+        assert type(val) == unicode
+        return val
+
     @hybrid_property
     def app_settings_value(self):
         v = self._app_settings_value