# HG changeset patch # User Mads Kiilerich # Date 2013-12-10 19:30:37 # Node ID 5095f484f74ca08eb68e388d1168d2e909e5e533 # Parent f322a2326019978b8617aac7d4daaaa9ed2908c3 changeset: don't crash if removed comment already has been removed diff --git a/kallithea/controllers/changeset.py b/kallithea/controllers/changeset.py --- a/kallithea/controllers/changeset.py +++ b/kallithea/controllers/changeset.py @@ -428,6 +428,8 @@ class ChangesetController(BaseRepoContro @jsonify def delete_comment(self, repo_name, comment_id): co = ChangesetComment.get(comment_id) + if not co: + raise HTTPBadRequest() owner = co.author.user_id == c.authuser.user_id repo_admin = h.HasRepoPermissionAny('repository.admin') if h.HasPermissionAny('hg.admin')() or repo_admin or owner: