# HG changeset patch # User Mads Kiilerich # Date 2016-05-04 01:18:25 # Node ID 52a10832bbb0a669612e8463e45ea547d4cf6f33 # Parent 98c3d9515cada54349ee343ab24ee7e1680aeb6e pullrequests: reword the grumpy "Rejected" to the more neutral and factual "Not approved" "Rejecting" could be considered rude and some reviewers were thus reluctant to use it. Rewording it might give reviewers a voice to better express their feelings. diff --git a/kallithea/model/db.py b/kallithea/model/db.py --- a/kallithea/model/db.py +++ b/kallithea/model/db.py @@ -2229,13 +2229,13 @@ class ChangesetStatus(Base, BaseModel): STATUS_NOT_REVIEWED = DEFAULT = 'not_reviewed' STATUS_APPROVED = 'approved' - STATUS_REJECTED = 'rejected' + STATUS_REJECTED = 'rejected' # is shown as "Not approved" - TODO: change database content / scheme STATUS_UNDER_REVIEW = 'under_review' STATUSES = [ (STATUS_NOT_REVIEWED, _("Not reviewed")), # (no icon) and default (STATUS_APPROVED, _("Approved")), - (STATUS_REJECTED, _("Rejected")), + (STATUS_REJECTED, _("Not approved")), (STATUS_UNDER_REVIEW, _("Under review")), ] STATUSES_DICT = dict(STATUSES)