# HG changeset patch # User Thomas De Schampheleire # Date 2015-06-11 08:18:14 # Node ID 5fb4e6f884cec710b34736756d4eadaa53dd51d0 # Parent a6accd29d038e694de0dfdc2316dd1b1bb72a06d changeset: reduce log level of stack trace on innocent exceptions When the user performs an unallowed action and a flash is displayed, there is no need to log the stack trace at 'error' level. Reduce the stack trace log to debug instead. diff --git a/kallithea/controllers/changeset.py b/kallithea/controllers/changeset.py --- a/kallithea/controllers/changeset.py +++ b/kallithea/controllers/changeset.py @@ -208,7 +208,7 @@ class ChangesetController(BaseRepoContro raise RepositoryError('Changeset range returned empty result') except(ChangesetDoesNotExistError,), e: - log.error(traceback.format_exc()) + log.debug(traceback.format_exc()) msg = _('Such revision does not exist for this repository') h.flash(msg, category='error') raise HTTPNotFound() @@ -378,7 +378,7 @@ class ChangesetController(BaseRepoContro dont_allow_on_closed_pull_request=True ) except StatusChangeOnClosedPullRequestError: - log.error(traceback.format_exc()) + log.debug(traceback.format_exc()) msg = _('Changing status on a changeset associated with ' 'a closed pull request is not allowed') h.flash(msg, category='warning')