# HG changeset patch # User Thomas De Schampheleire # Date 2015-06-30 17:55:09 # Node ID 67ff34c2dcfbc3709ae401aa35a90a6562dec534 # Parent e2f9a14a54e0159ee38193a7cb48623d79f1f8bc autocomplete: remove redundant specification of responseSchema YAHOO.util.DataSource.responseSchema determines which fields from the data source are returned upon requests. In the case of user/group autocompletion, the data source is a static JavaScript array containing only the relevant fields. When not specifying a responseSchema, all fields of the selected entry are returned, which is fine (in fact, the responseSchema currently specified just mentions all fields, redundantly). diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js --- a/kallithea/public/js/base.js +++ b/kallithea/public/js/base.js @@ -1243,15 +1243,9 @@ var _MembersAutoComplete = function (div // DataScheme for members var memberDS = new YAHOO.util.FunctionDataSource(matchAll); - memberDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "grname", "grmembers", "gravatar_lnk", "gravatar_size"] - }; // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; // Instantiate AutoComplete for perms var membersAC = new YAHOO.widget.AutoComplete(divid, cont, memberDS); @@ -1309,10 +1303,6 @@ var MentionsAutoComplete = function (div // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; - // Instantiate AutoComplete for mentions var ownerAC = new YAHOO.widget.AutoComplete(divid, cont, ownerDS); ownerAC.useShadow = false; @@ -1446,10 +1436,6 @@ var PullRequestAutoComplete = function ( // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; - // Instantiate AutoComplete for mentions var reviewerAC = new YAHOO.widget.AutoComplete(divid, cont, ownerDS); reviewerAC.useShadow = false;