# HG changeset patch # User Jan Heylen # Date 2015-12-24 21:28:19 # Node ID 720339c9f81cbdde035f476545f1657c2b9f0b28 # Parent 1666c8c7d92596ea6610a7bf8f6a78e3a9e3d06b diff: get collapse target via .attr instead of .prop Commit 3f017db297c4 was not fully tested and broke collapse/expand of diffs on changesets. $button is not a link with a target and the target can thus not be retrieved with .prop('target'); $button is just a span that happens to have a custom attribute with the name 'target'. We thus revert back to the old way of retrieving it with .attr('target'). (It would perhaps be even better to use data attributes and name it data-target and use .data('target') ...) diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js --- a/kallithea/public/js/base.js +++ b/kallithea/public/js/base.js @@ -1886,7 +1886,7 @@ var branchSort = function(results, conta $(document).ready(function(){ $('.diff-collapse-button').click(function(e) { var $button = $(e.currentTarget); - var $target = $('#' + $button.prop('target')); + var $target = $('#' + $button.attr('target')); if($target.hasClass('hidden')){ $target.removeClass('hidden'); $button.html("↑ {0} ↑".format(_TM['Collapse Diff']));