# HG changeset patch # User Mads Kiilerich # Date 2015-01-21 17:35:11 # Node ID 787f30a1a9966c50c9809188eb51dea7c7a146d1 # Parent dd85884243a7283334fea2b38200c158022430a0 tests: make checkSessionFlash check the last flash message only but show all on failure diff --git a/kallithea/tests/__init__.py b/kallithea/tests/__init__.py --- a/kallithea/tests/__init__.py +++ b/kallithea/tests/__init__.py @@ -213,12 +213,13 @@ class TestController(BaseTestCase): def _get_logged_user(self): return User.get_by_username(self._logged_username) - def checkSessionFlash(self, response, msg): - self.assertTrue('flash' in response.session, - msg='Response session have no flash key' % response.session) - if not any(msg in m for level, m in response.session['flash']): - for level, m in response.session['flash']: - msg = u'msg `%s` not found in session flash: got `%s` instead' % (msg, m) - self.fail(safe_str(msg)) - msg = u'msg `%s` not found in empty session flash' % (msg) - self.fail(safe_str(msg)) + def checkSessionFlash(self, response, msg, skip=0): + try: + level, m = response.session['flash'][-1 - skip] + if msg in m: + return + except IndexError: + pass + self.fail(safe_str(u'msg `%s` not found in session flash skipping %s: %s' % + (msg, skip, + ', '.join('`%s`' % m for level, m in response.session['flash']))))