# HG changeset patch # User Mads Kiilerich # Date 2016-06-14 01:12:09 # Node ID 7db1bcf1d95ba27cbbeabaf0b0ca2c31afd66b46 # Parent 5c549b26231afd7252d3590f8f54d698346b71c5 tests: drop setting EMAIL environment variable before git commit - it doesn't work on Windows and seems unnecessary To minimize the risk, we still remove it from the environment used for running the commands. diff --git a/kallithea/tests/other/manual_test_vcs_operations.py b/kallithea/tests/other/manual_test_vcs_operations.py --- a/kallithea/tests/other/manual_test_vcs_operations.py +++ b/kallithea/tests/other/manual_test_vcs_operations.py @@ -67,6 +67,7 @@ class Command(object): testenv = dict(os.environ) testenv['LANG'] = 'en_US.UTF-8' testenv['LANGUAGE'] = 'en_US:en' + testenv.pop('EMAIL', None) # might not be necessary p = Popen(command, shell=True, stdout=PIPE, stderr=PIPE, cwd=self.cwd, env=testenv) stdout, stderr = p.communicate() if DEBUG: @@ -125,7 +126,7 @@ def _add_files_and_push(vcs, DEST, **kwa i, author_str, added_file ) elif vcs == 'git': - cmd = """EMAIL="me@example.com" git commit -m "committed new %s" --author "%s" "%s" """ % ( + cmd = """git commit -m "committed new %s" --author "%s" "%s" """ % ( i, author_str, added_file ) Command(cwd).execute(cmd)