# HG changeset patch
# User Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
# Date 2015-06-30 22:30:57
# Node ID 81c70071b6f22df942834e0d8ba1b1459e3ee73f
# Parent  18a600874f40fb6cc9370fa46cff5544de110467

autocomplete: consistently show 'username (Full Name)'

diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js
--- a/kallithea/public/js/base.js
+++ b/kallithea/public/js/base.js
@@ -1183,8 +1183,7 @@ var autocompleteFormatter = function (oR
         var grmembers = oResultData.grmembers;
         var grnameMatchIndex = grname.toLowerCase().indexOf(query);
         var grprefix = "{0}: ".format(_TM['Group']);
-        var grsuffix = " (" + grmembers + "  )";
-        var grsuffix = " ({0}  {1})".format(grmembers, _TM['members']);
+        var grsuffix = " ({0} {1})".format(grmembers, _TM['members']);
 
         if (grnameMatchIndex > -1) {
             return autocompleteGravatar(grprefix + autocompleteHighlightMatch(grname, query, grnameMatchIndex) + grsuffix, null, null, true);
@@ -1201,7 +1200,7 @@ var autocompleteFormatter = function (oR
         var fnameMatchIndex = fname.toLowerCase().indexOf(query),
             lnameMatchIndex = lname.toLowerCase().indexOf(query),
             nnameMatchIndex = nname.toLowerCase().indexOf(query),
-            displayfname, displaylname, displaynname;
+            displayfname, displaylname, displaynname, displayname;
 
         if (fnameMatchIndex > -1) {
             displayfname = autocompleteHighlightMatch(fname, query, fnameMatchIndex);
@@ -1216,12 +1215,17 @@ var autocompleteFormatter = function (oR
         }
 
         if (nnameMatchIndex > -1) {
-            displaynname = "(" + autocompleteHighlightMatch(nname, query, nnameMatchIndex) + ")";
+            displaynname = autocompleteHighlightMatch(nname, query, nnameMatchIndex);
         } else {
-            displaynname = nname ? "(" + nname + ")" : "";
+            displaynname = nname;
         }
 
-        return autocompleteGravatar(displayfname + " " + displaylname + " " + displaynname, oResultData.gravatar_lnk, oResultData.gravatar_size);
+        displayname = displaynname;
+        if (displayfname && displaylname) {
+            displayname = "{0} {1} ({2})".format(displayfname, displaylname, displayname);
+        }
+
+        return autocompleteGravatar(displayname, oResultData.gravatar_lnk, oResultData.gravatar_size);
     } else {
         return '';
     }