# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 2015-03-06 16:21:24
# Node ID 87f5ca5cbd7ea64d37e731c4b1a555fc96bab101
# Parent  8b08599d4b088688ec09d05291fb233a68e29db5

compare: don't use sql 'in' on empty sets

diff --git a/kallithea/model/db.py b/kallithea/model/db.py
--- a/kallithea/model/db.py
+++ b/kallithea/model/db.py
@@ -1359,6 +1359,8 @@ class Repository(Base, BaseModel):
         cmts = ChangesetComment.query()\
             .filter(ChangesetComment.repo == self)
         if revisions is not None:
+            if not revisions:
+                return [] # don't use sql 'in' on empty set
             cmts = cmts.filter(ChangesetComment.revision.in_(revisions))
         grouped = collections.defaultdict(list)
         for cmt in cmts.all():