# HG changeset patch # User Thomas De Schampheleire # Date 2018-03-16 22:08:46 # Node ID 8a1caf0f259240833b5733763414baf681449911 # Parent 22e80164295fa6feac64d9d3d71b12951c4e0c09 tests: vcs: recreate_repo_per_test is really optional While the documentation says this attribute is required, most tests do not set it when the default value is fine. Follow-through that convention and update the documentation. diff --git a/kallithea/tests/vcs/base.py b/kallithea/tests/vcs/base.py --- a/kallithea/tests/vcs/base.py +++ b/kallithea/tests/vcs/base.py @@ -18,7 +18,7 @@ class _BackendTestMixin(object): This is a backend independent test case class which should be created with ``type`` method. - It is required to set following attributes at subclass: + It is possible to set following attributes at subclass: - ``backend_alias``: alias of used backend (see ``vcs.BACKENDS``) - ``recreate_repo_per_test``: If set to ``False``, repo would NOT be created diff --git a/kallithea/tests/vcs/test_changesets.py b/kallithea/tests/vcs/test_changesets.py --- a/kallithea/tests/vcs/test_changesets.py +++ b/kallithea/tests/vcs/test_changesets.py @@ -53,7 +53,6 @@ class TestBaseChangeset(object): class _ChangesetsWithCommitsTestCaseixin(_BackendTestMixin): - recreate_repo_per_test = True @classmethod def _get_commits(cls): diff --git a/kallithea/tests/vcs/test_inmemchangesets.py b/kallithea/tests/vcs/test_inmemchangesets.py --- a/kallithea/tests/vcs/test_inmemchangesets.py +++ b/kallithea/tests/vcs/test_inmemchangesets.py @@ -25,8 +25,6 @@ from kallithea.tests.vcs.base import _Ba class InMemoryChangesetTestMixin(_BackendTestMixin): - recreate_repo_per_test = True - @classmethod def _get_commits(cls): # Note: this is slightly different than the regular _get_commits methods