# HG changeset patch # User domruf # Date 2017-05-10 22:50:19 # Node ID a9b169709aea7559b391a50d90a6e89bfa739867 # Parent 4188b49af031e698b111015b51304b180bd58f63 hg: fix except clauses order pylint found 'Bad except clauses order (LookupError is an ancestor class of IndexError)'. This fix will in some cases give better error messages. diff --git a/kallithea/lib/vcs/backends/hg/repository.py b/kallithea/lib/vcs/backends/hg/repository.py --- a/kallithea/lib/vcs/backends/hg/repository.py +++ b/kallithea/lib/vcs/backends/hg/repository.py @@ -421,12 +421,12 @@ class MercurialRepository(BaseRepository try: revision = hex(self._repo.lookup(revision)) + except (IndexError, ValueError, RepoLookupError, TypeError): + msg = ("Revision %s does not exist for %s" % (revision, self)) + raise ChangesetDoesNotExistError(msg) except (LookupError, ): msg = ("Ambiguous identifier `%s` for %s" % (revision, self)) raise ChangesetDoesNotExistError(msg) - except (IndexError, ValueError, RepoLookupError, TypeError): - msg = ("Revision %s does not exist for %s" % (revision, self)) - raise ChangesetDoesNotExistError(msg) return revision