# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 2016-11-15 22:53:41
# Node ID acdd8d23e362f36737327d603ebf6bb4a584b9e1
# Parent  a2db1b9be04dfd0ff0da4a40b70339aba97a7c55

repo_groups: set c.active when displaying repo creation form errors through repo_group_edit.html

Writing failing tests revealed a crash.

diff --git a/kallithea/controllers/admin/repo_groups.py b/kallithea/controllers/admin/repo_groups.py
--- a/kallithea/controllers/admin/repo_groups.py
+++ b/kallithea/controllers/admin/repo_groups.py
@@ -236,7 +236,7 @@ class RepoGroupsController(BaseControlle
             group_name = new_gr.group_name
             #TODO: in future action_logger(, '', '', '', self.sa)
         except formencode.Invalid as errors:
-
+            c.active = 'settings'
             return htmlfill.render(
                 render('admin/repo_groups/repo_group_edit.html'),
                 defaults=errors.value,
diff --git a/kallithea/tests/functional/test_repo_groups.py b/kallithea/tests/functional/test_repo_groups.py
--- a/kallithea/tests/functional/test_repo_groups.py
+++ b/kallithea/tests/functional/test_repo_groups.py
@@ -17,6 +17,13 @@ class TestRepoGroupsController(TestContr
 
         group_name = 'foo'
 
+        # creation with form error
+        response = self.app.post(url('repos_groups'),
+                                         {'group_name': group_name,
+                                          '_authentication_token': self.authentication_token()})
+        response.mustcontain('name="group_name" type="text" value="%s"' % group_name)
+        response.mustcontain('<!-- for: group_description -->')
+
         # creation
         response = self.app.post(url('repos_groups'),
                                          {'group_name': group_name,
@@ -30,6 +37,13 @@ class TestRepoGroupsController(TestContr
         response = self.app.get(url('edit_repo_group', group_name=group_name))
         response.mustcontain('>lala<')
 
+        # edit with form error
+        response = self.app.post(url('update_repos_group', group_name=group_name),
+                                         {'group_name': group_name,
+                                          '_authentication_token': self.authentication_token()})
+        response.mustcontain('name="group_name" type="text" value="%s"' % group_name)
+        response.mustcontain('<!-- for: group_description -->')
+
         # edit
         response = self.app.post(url('update_repos_group', group_name=group_name),
                                          {'group_name': group_name,
@@ -38,6 +52,7 @@ class TestRepoGroupsController(TestContr
         self.checkSessionFlash(response, 'Updated repository group %s' % group_name)
         response = response.follow()
         response.mustcontain('name="group_name" type="text" value="%s"' % group_name)
+        response.mustcontain(no='<!-- for: group_description -->')
         response.mustcontain('>lolo<')
 
         # listing