# HG changeset patch
# User Mads Kiilerich <mads@kiilerich.com>
# Date 2019-08-12 12:54:01
# Node ID d9e37f7fd35b1ad99ea6cc1611decde93a821f1c
# Parent  62822054a1e23ab9ad1de8b8aa70f2fe60fdda54

docs: always use dev_requirements.txt together with main version constraints in setup.py

pip isn't good at considering old constraints when installing or updating
packages later. Instead, install everything at once.

Note: pip and setuptools are usually installed automatically and could perhaps
be removed from documentation. But for now, let's keep it.

diff --git a/Jenkinsfile b/Jenkinsfile
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -44,8 +44,7 @@ node {
     }
     stage('setup') {
         def virtualenvscript = """$activatevirtualenv
-            pip install --upgrade -e .
-            pip install -r dev_requirements.txt
+            pip install --upgrade -e . -r dev_requirements.txt
             python setup.py compile_catalog
             """
         if (isUnix()) {
diff --git a/docs/contributing.rst b/docs/contributing.rst
--- a/docs/contributing.rst
+++ b/docs/contributing.rst
@@ -35,8 +35,7 @@ To get started with Kallithea developmen
         virtualenv ../kallithea-venv
         source ../kallithea-venv/bin/activate
         pip install --upgrade pip setuptools
-        pip install --upgrade -e .
-        pip install --upgrade -r dev_requirements.txt
+        pip install --upgrade -e . -r dev_requirements.txt
         kallithea-cli config-create my.ini
         kallithea-cli db-create -c my.ini --user=user --email=user@example.com --password=password --repos=/tmp
         kallithea-cli front-end-build
diff --git a/scripts/make-release b/scripts/make-release
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -19,8 +19,7 @@ virtualenv -p python2 "$venv"
 . "$venv/bin/activate"
 
 echo "Install/verify tools needed for building and uploading stuff"
-pip install --upgrade -e .
-pip install --upgrade -r dev_requirements.txt twine
+pip install --upgrade -e . -r dev_requirements.txt twine
 
 echo "Cleanup and update copyrights ... and clean checkout"
 scripts/run-all-cleanup
diff --git a/scripts/validate-commits b/scripts/validate-commits
--- a/scripts/validate-commits
+++ b/scripts/validate-commits
@@ -37,9 +37,7 @@ for rev in $(hg log -r "$1" -T '{node}\n
     virtualenv -p "$(command -v python2)" "$venv"
     source "$venv/bin/activate"
     pip install --upgrade pip setuptools
-    pip install -e .
-    pip install -r dev_requirements.txt
-    pip install python-ldap python-pam
+    pip install -e . -r dev_requirements.txt python-ldap python-pam
 
     # run-all-cleanup
     scripts/run-all-cleanup