# HG changeset patch # User Mads Kiilerich # Date 2019-12-01 21:02:43 # Node ID db8531aabfdc21f1819ecfc8f785b628fb65eaec # Parent 04dded89aa874ee04d0e6b90eac6d2af73fa92a1 routing: drop default f_path for changelog_file_home There is no point in creating a changelog_file_home URL without specifying f_path. The default value of None is thus never any good. And especially, it is unclear what a value of None really means. diff --git a/kallithea/config/routing.py b/kallithea/config/routing.py --- a/kallithea/config/routing.py +++ b/kallithea/config/routing.py @@ -673,7 +673,7 @@ def make_map(config): controller='changelog', conditions=dict(function=check_repo)) rmap.connect('changelog_file_home', '/{repo_name:.*?}/changelog/{revision}/{f_path:.*}', - controller='changelog', f_path=None, + controller='changelog', conditions=dict(function=check_repo)) rmap.connect('changelog_details', '/{repo_name:.*?}/changelog_details/{cs}',