# HG changeset patch # User Thomas De Schampheleire # Date 2015-06-19 15:40:27 # Node ID ea284e51ec2eb80cbf3d3552798b9a060d1746b1 # Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47 pullrequest: warn for duplication of reviewer handling with base.js diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js --- a/kallithea/public/js/base.js +++ b/kallithea/public/js/base.js @@ -1473,6 +1473,9 @@ var addReviewMember = function(id,fname, var gravatarelm = 'gravatar'.format(gravatar_size, gravatar_link); if (!gravatar_link) gravatarelm = ''.format(gravatar_size); + // WARNING: the HTML below is duplicate with + // kallithea/templates/pullrequests/pullrequest_show.html + // If you change something here it should be reflected in the template too. var element = ( '
  • \n'+ '
    \n'+ diff --git a/kallithea/templates/pullrequests/pullrequest_show.html b/kallithea/templates/pullrequests/pullrequest_show.html --- a/kallithea/templates/pullrequests/pullrequest_show.html +++ b/kallithea/templates/pullrequests/pullrequest_show.html @@ -212,6 +212,9 @@ ${self.repo_context_bar('showpullrequest
      %for member,status in c.pull_request_reviewers: + ## WARNING: the HTML below is duplicate with + ## kallithea/public/js/base.js + ## If you change something here it should be reflected in the template too.