kallithea Changeset - 00c76c4e019c

Changeset - 00c76c4e019c

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 11 years ago 2014-08-12 13:08:23
madski@unity3d.com

pull request: make it more visible that reviewers only are added/removed after save

1 file changed with 5 insertions and 2 deletions:

kallithea/public/js/base.js

0 comments (0 inline, 0 general)

kallithea/public/js/base.js

➞

Show inline comments

@@ @@ -1502,7 +1502,7 @@ var addReviewMember = function(id,fname, @@
         '         <input type="hidden" value="{2}" name="review_members" />\n'+
         '         <div class="reviewer_member_remove action_button" onclick="removeReviewMember({2})">\n'+
         '             <i class="icon-remove-sign" style="color: #FF4444;"></i>\n'+
         '         </div>\n'+
+        '         </div> *\n'+
         '       </div>\n'+
         '     </li>\n'
         ).format(gravatar_link, displayname, id);
@@ @@ -1518,7 +1518,10 @@ var addReviewMember = function(id,fname, @@
+}
 var removeReviewMember = function(reviewer_id, repo_name, pull_request_id){
     $('#reviewer_{0}'.format(reviewer_id)).remove();
     var $li = $('#reviewer_{0}'.format(reviewer_id));
     $li.find('div div').css("text-decoration", "line-through");
     $li.find('input').remove();
     $li.find('.reviewer_member_remove').remove();
+}
 /* handle "Save Changes" of addReviewMember and removeReviewMember on PR */

0 comments (0 inline, 0 general)